fix(ci): e2e — let Playwright manage both servers (fixes the 2-hour hang)
CI / frontend (push) Successful in 1m49s
CI / storybook-a11y (push) Successful in 4m55s
CI / backend (push) Successful in 1m18s
CI / e2e (push) Successful in 2m50s
CI / codeql (csharp) (push) Failing after 2m3s
CI / codeql (javascript-typescript) (push) Failing after 1m29s
CI / api-client-drift (push) Successful in 1m42s
CI / frontend (push) Successful in 1m49s
CI / storybook-a11y (push) Successful in 4m55s
CI / backend (push) Successful in 1m18s
CI / e2e (push) Successful in 2m50s
CI / codeql (csharp) (push) Failing after 2m3s
CI / codeql (javascript-typescript) (push) Failing after 1m29s
CI / api-client-drift (push) Successful in 1m42s
The e2e job backgrounded `dotnet run &` and `ng serve &` in separate Actions steps, then `npx wait-on` (no timeout) in a later step. A process started with `&` in one step is killed when that step's shell exits, so wait-on waited forever on servers that were already gone — the job hung until the runner's hard limit (~2h; Gitea's act_runner doesn't reliably enforce timeout-minutes). Move both servers into Playwright's `webServer` (an array: backend + `npm start`), so Playwright starts them, waits for readiness, runs the suite, and tears them down in the one `npm run e2e` process — CI and local alike. The CI e2e job is now just npm ci / playwright install / npm run e2e. `reuseExistingServer` is on locally (reuses a running app, incl. the docker stack) and off in CI (fresh start). Verified locally via `CI=1 npm run e2e` against free ports + a clean db: both smoke tests pass in ~15s (no hang). The earlier local failure was leftover SQLite state (WP-22) from a dirty run resuming a Concept — CI checks out fresh, so its db is always empty. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
+4
-3
@@ -25,6 +25,7 @@ if [[ "${1:-}" == "--full" ]]; then
|
||||
fi
|
||||
|
||||
printf '\n\033[1;32m✔ local CI passed\033[0m\n'
|
||||
printf 'Note: the e2e job is not run here — it needs the backend + ng serve up. Run:\n'
|
||||
printf ' (backend) dotnet run --project backend/src/BigRegister.Api --urls http://localhost:5000 &\n'
|
||||
printf ' (frontend) npx ng serve & then npm run e2e\n'
|
||||
printf 'Note: the e2e job is not chained here (it is slow). Run it standalone with:\n'
|
||||
printf ' npm run e2e\n'
|
||||
printf 'Playwright starts the backend + ng serve itself (playwright.config.ts webServer),\n'
|
||||
printf 'reusing an already-running app on 4200/5000 if present.\n'
|
||||
|
||||
Reference in New Issue
Block a user