test(backend): split RuleTests.cs by aggregate, refresh DDD doc (WP-71)

RuleTests.cs held five aggregates' rules as nested classes in one file, misaligned with Domain/<Aggregate>/ and with the Acceptance/Builders/ folder convention WP-70 started. Split into Domain/<Aggregate>RuleTests.cs (pure move — same names, same bodies, same count) plus a new ApplicationRuleTests.cs (the enum invariant moved out of the WebApplicationFactory-booting ApplicationTests.cs, since it's a pure Enum.GetNames check with no business needing a web host) and OrgTemplateRuleTests.cs (RejectDraft had no direct unit test before, only endpoint coverage). libs/shared/docs/layers.mdx still taught the pre-WP-67 shape (six contexts, no apps/libs split, enforcement via ESLint) — updated to the real monorepo structure and to dependency-cruiser as the actual enforcement mechanism. Adds specs for registration.policy.ts's isStatusConsistent (untested; its backend mirror is) and both apps' auth/domain/session.ts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-18 20:25:05 +02:00
parent b937e55ad3
commit 28c0a250e7
13 changed files with 409 additions and 254 deletions
@@ -0,0 +1,57 @@
+using BigRegister.Domain.Registrations;
+
+namespace BigRegister.Tests.Domain;
+
+public class HerregistratieRuleTests
+{
+  private static Registration Active(DateOnly deadline) => new(
+      "19012345601", "Test", "Arts",
+      new DateOnly(2012, 9, 1), new DateOnly(1985, 3, 14),
+      new RegistrationStatus(StatusTag.Geregistreerd, HerregistratieDatum: deadline));
+
+  [Fact]
+  public void Eligible_within_window()
+  {
+    var (eligible, reason) = HerregistratieRule.Evaluate(
+        Active(new DateOnly(2027, 3, 1)), today: new DateOnly(2026, 6, 26));
+    Assert.True(eligible);
+    Assert.Contains("12 maanden", reason);
+  }
+
+  [Fact]
+  public void Not_eligible_before_window()
+  {
+    var (eligible, _) = HerregistratieRule.Evaluate(
+        Active(new DateOnly(2027, 3, 1)), today: new DateOnly(2025, 1, 1));
+    Assert.False(eligible);
+  }
+
+  [Fact]
+  public void Eligible_on_window_boundary()
+  {
+    // window opens exactly 12 months before the deadline
+    var (eligible, _) = HerregistratieRule.Evaluate(
+        Active(new DateOnly(2027, 3, 1)), today: new DateOnly(2026, 3, 1));
+    Assert.True(eligible);
+  }
+
+  [Fact]
+  public void Suspended_is_not_eligible()
+  {
+    var reg = Active(new DateOnly(2027, 3, 1)) with
+    {
+      Status = new RegistrationStatus(StatusTag.Geschorst, GeschorstTot: new DateOnly(2027, 1, 1), Reden: "x"),
+    };
+    var (eligible, _) = HerregistratieRule.Evaluate(reg, today: new DateOnly(2026, 6, 26));
+    Assert.False(eligible);
+  }
+
+  [Fact]
+  public void Status_consistency_invariant()
+  {
+    Assert.True(HerregistratieRule.IsStatusConsistent(
+        new RegistrationStatus(StatusTag.Geregistreerd, HerregistratieDatum: new DateOnly(2027, 3, 1))));
+    Assert.False(HerregistratieRule.IsStatusConsistent(
+        new RegistrationStatus(StatusTag.Geregistreerd)));
+  }
+}