Merge RB-28 — add BLOB_PRESENTER, unlock the blob-to-browser success paths

TE-006: StamdataStore.download(), BriefStore.previewLetter() and
OrgTemplateStore.proefbrief() each ended in raw DOM blob calls jsdom cannot
meaningfully execute, so their success paths were unassertable and
download()'s two-clause guard true-branch was permanently dark.
BLOB_PRESENTER mirrors the SESSION_PORT shape; all three commands go through
it. download()'s branch coverage goes from 40.5% to 67.6%, and
org-template.store.ts gets its first spec at all.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

# Conflicts:
#	docs/project/refactor-backlog-setup/refactor-backlog/99-backlog.md
#	libs/shared/docs/behaviour-spec.mdx
This commit is contained in:
eho
2026-08-28 08:39:09 +02:00
10 changed files with 477 additions and 34 deletions
@@ -0,0 +1,37 @@
import { InjectionToken } from '@angular/core';
/**
* A shared seam for handing a generated `Blob` to the browser, WITHOUT the calling
* command inlining `URL.createObjectURL`/`window.open`/`document.createElement('a')`
* as its own last statement (TE-006) — those calls are unassertable in jsdom because
* they are the end of the command, not a value the spec can intercept. A recording
* fake satisfies this shape in specs; `realBlobPresenter` is the production default.
*/
export interface BlobPresenter {
/** Open a blob in a new tab (e.g. a rendered letter preview). Never revokes the
object URL — the tab outlives this call, and the POC treats the leak as cheap
(see `BriefStore.previewLetter`'s original comment). */
open(blob: Blob): void;
/** Trigger a browser download of a blob under the given file name, then revoke the
object URL once the click has been dispatched. */
download(blob: Blob, filename: string): void;
}
const realBlobPresenter: BlobPresenter = {
open(blob: Blob) {
window.open(URL.createObjectURL(blob), '_blank');
},
download(blob: Blob, filename: string) {
const url = URL.createObjectURL(blob);
const a = document.createElement('a');
a.href = url;
a.download = filename;
a.click();
URL.revokeObjectURL(url);
},
};
export const BLOB_PRESENTER = new InjectionToken<BlobPresenter>('BLOB_PRESENTER', {
providedIn: 'root',
factory: () => realBlobPresenter,
});