refactor: strip WP-/RB- ticket refs from apps and libs (RD-18)

204 WP-NN/RB-NN comments named a closed ticket instead of the code they sit next to. git blame already records history and stays correct when code moves; the comment does not. This sweep removes the reference and keeps the sentence, across 95 files in apps/ and libs/ plus the behaviour-spec generator's header text. Eleven references stay: five story files justify an a11y disable per the README's rule, and one line in a11y.mdx documents that convention. Two sentences needed a rewrite, not a deletion, so the reference's meaning survives its removal. behaviour-spec.mdx is regenerated, not hand-edited. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-04 21:23:07 +02:00
parent 3895588b9a
commit dd11eafe50
102 changed files with 361 additions and 197 deletions
@@ -20,7 +20,7 @@ export const routes: Routes = [
      },
      {
        path: 'aanvraag/:id',
-        // Same capability the werkvoorraad list itself is gated by (WP-64/65) — the
+        // Same capability the werkvoorraad list itself is gated by — the
        // detail page is reachable only from a row already filtered to that capability.
        canActivate: [capabilityGuard('aanvraag:beoordelen')],
        loadComponent: () =>
@@ -36,14 +36,14 @@ export const routes: Routes = [
      },
      {
        path: 'beheer/audit',
-        // Admin-only authz/PII-reveal audit trail (WP-41/42). capabilityGuard denies-by-default
+        // Admin-only authz/PII-reveal audit trail. capabilityGuard denies-by-default
        // unless GET /me resolved `cases:manage` (reused for audit read). Backend re-enforces.
        canActivate: [capabilityGuard('cases:manage')],
        loadComponent: () => import('@beheer/ui/audit.page').then((m) => m.AuditPage),
      },
      {
        path: 'beheer/functies',
-        // Admin-only feature-flag toggles (WP-47), gated by `flags:manage`.
+        // Admin-only feature-flag toggles, gated by `flags:manage`.
        canActivate: [capabilityGuard('flags:manage')],
        loadComponent: () =>
          import('@beheer/ui/feature-flags.page').then((m) => m.FeatureFlagsPage),
@@ -4,7 +4,7 @@ import { MEDEWERKER_ID, currentRollen } from './medewerker';

 /**
 * Infrastructure: resolves the current medewerker identity into a `Principal`
- * (ADR-C-004/RB-13). Stands in for a real employee-SSO redirect flow (ADR-0002 §3,
+ * (ADR-C-004). Stands in for a real employee-SSO redirect flow (ADR-0002 §3,
 * "out of scope here") — there is no credential to enter and, unlike `DigidAdapter`'s
 * BSN check, no format to reject, so `authenticate()` takes no input and returns the
 * `Principal` directly rather than a `Result` with an error variant that can never
@@ -2,7 +2,7 @@ import { Component, output } from '@angular/core';
 import { ButtonComponent } from '@shared/ui/button/button.component';

 /**
- * Organism: employee-SSO-style mock login (ADR-C-004/RB-13). No real auth — and,
+ * Organism: employee-SSO-style mock login (ADR-C-004). No real auth — and,
 * unlike the SSP's DigiD form, no credential to enter at all: a Behandelaar has no
 * BSN, and this app has no password of its own to check either way. There is
 * nothing to compose beyond one button, which is itself evidence for the ADR — the
@@ -8,7 +8,7 @@ import {

 type Err = Error | undefined;

-/** One aanvraag's beoordeling detail (WP-65) — a root singleton like `WerkvoorraadStore`.
+/** One aanvraag's beoordeling detail — a root singleton like `WerkvoorraadStore`.
    Keyed by id: navigating to a different case resets to Loading. */
@Injectable({ providedIn: 'root' })
 export class BeoordelingStore {
@@ -8,7 +8,7 @@ import {

 type Err = Error | undefined;

-/** The behandelaar's queue (WP-64) — a root singleton like `AdminCasesStore`'s ssp
+/** The behandelaar's queue — a root singleton like `AdminCasesStore`'s ssp
    counterpart. Fetch + parse at the trust boundary, publish as RemoteData. */
@Injectable({ providedIn: 'root' })
 export class WerkvoorraadStore {
@@ -2,8 +2,8 @@ import { formatDatumNl } from '@shared/kernel/datum';
 import { AanvraagType } from './werkvoorraad-item';
 import { BeoordelingStatus, BeoordelingView } from './beoordeling';

-/** View-model mapping shared by the werkvoorraad list (WP-64) and the beoordeling
-    detail screen (WP-65): type/status → labels. Pure, no Angular. Lives here (not in
+/** View-model mapping shared by the werkvoorraad list and the beoordeling
+    detail screen: type/status → labels. Pure, no Angular. Lives here (not in
    `werkvoorraad-item-view.ts`) because `BeoordelingStatus` is the wider of the two
    status unions — `werkvoorraad-item-view.ts` re-exports these for its own use. */

@@ -1,8 +1,8 @@
 import { AanvraagType } from './werkvoorraad-item';

 /**
- * A case's full status lifecycle as the beoordeling detail screen sees it (WP-65) —
- * wider than `WerkvoorraadStatus` (WP-64), which only ever sees the two "still open"
+ * A case's full status lifecycle as the beoordeling detail screen sees it —
+ * wider than `WerkvoorraadStatus`, which only ever sees the two "still open"
 * tags. This is the same five-tag union ssp's `AanvraagStatus` models (minus `Concept`
 * — the detail endpoint 404s a Concept, it isn't a case a behandelaar can treat yet).
 */
@@ -1,6 +1,6 @@
 import { Result, assertNever } from '@shared/kernel/fp';

-/** The three actions the beoordeling screen offers a behandelaar (WP-65b) — mirrors the
+/** The three actions the beoordeling screen offers a behandelaar — mirrors the
    backend's `Besluit` enum member names 1:1 (the wire convention: a string, not a raw
    enum — see `RecordBesluitRequest`). */
 const BESLUIT_TAGS = ['Goedkeuren', 'Afwijzen', 'MeerInfoOpvragen'] as const;
@@ -1,5 +1,5 @@
 /**
- * A queue entry as the behandelportal sees it (WP-64) — the parsed, domain-side view
+ * A queue entry as the behandelportal sees it — the parsed, domain-side view
 * of the backend's cross-owner `GET /werkvoorraad`. Pure types, no Angular.
 *
 * The status union is narrower than the SSP's full `AanvraagStatus` (ssp's
@@ -13,7 +13,7 @@ import {
 import { AanvraagType } from '@behandeling/domain/werkvoorraad-item';

 /**
- * Infrastructure adapter for the beoordeling detail read (WP-65) — the only place its
+ * Infrastructure adapter for the beoordeling detail read — the only place its
 * HTTP lives (ADR-0001 anti-corruption boundary). The untrusted response is validated +
 * mapped to domain by the parse* boundary below.
 */
@@ -3,7 +3,7 @@ import { ApiClient } from '@shared/infrastructure/api-client';
 import { Valid } from '@behandeling/domain/besluit.machine';

 /**
- * Infrastructure adapter for recording a behandelaar's decision (WP-65b) — the single
+ * Infrastructure adapter for recording a behandelaar's decision — the single
 * place its HTTP lives. No return value: a successful call means the server accepted
 * the transition; the caller reloads `BeoordelingStore` to see the new status (the
 * server, not this adapter, re-validates and is the authority).
@@ -8,7 +8,7 @@ import {
 } from '@behandeling/domain/werkvoorraad-item';

 /**
- * Infrastructure adapter for the behandelportal's queue read (WP-64) — the only
+ * Infrastructure adapter for the behandelportal's queue read — the only
 * place its HTTP lives (ADR-0001 anti-corruption boundary). The untrusted response
 * is validated + mapped to the (narrower) queue domain shape by the parse* boundary
 * below; a case whose status isn't `Ingediend`/`InBehandeling` is a parse error, not
@@ -1,7 +1,7 @@
 import { Component, input } from '@angular/core';
 import { BeoordelingDocument } from '@behandeling/domain/beoordeling';

-/** Organism: the documents linked to an aanvraag (WP-65) — plain links to the existing
+/** Organism: the documents linked to an aanvraag — plain links to the existing
    (pre-existing, unauthenticated — same as ssp's own document previews) content
    endpoint. No new shared atom: a context-local list, not a reusable building block. */
@Component({
@@ -14,8 +14,8 @@ import { BeoordelingDocumentenComponent } from '@behandeling/ui/beoordeling-docu
 import { BesluitFormComponent } from '@behandeling/ui/besluit-form/besluit-form.component';

 /**
- * Page: one aanvraag's beoordeling detail (WP-65). The werkvoorraad list (WP-64) links
- * here. `canBesluiten` (server-computed, ADR-0001) gates the decision form (WP-65b) —
+ * Page: one aanvraag's beoordeling detail. The werkvoorraad list links
+ * here. `canBesluiten` (server-computed, ADR-0001) gates the decision form —
 * the page never recomputes the lifecycle itself. On a recorded decision the form emits
 * `decided`, and the page just reloads (the server is the authority on the new status).
 */
@@ -14,7 +14,7 @@ import { BesluitState, BesluitMsg, initial, reduce } from '@behandeling/domain/b
 import { createSubmitBesluit } from '@behandeling/application/submit-besluit';

 /**
- * Organism: the decision form (WP-65b) — goedkeuren/afwijzen/meer-info-opvragen. Same
+ * Organism: the decision form — goedkeuren/afwijzen/meer-info-opvragen. Same
 * idiom as every other form in this house (`change-request-form`): all state in one
 * signal driven by the pure `reduce` (besluit.machine.ts), submitted via a `submit-*`
 * command returning `Result`. The server re-validates the transition and is the
@@ -4,9 +4,9 @@ import { ApplicationLinkComponent } from '@shared/ui/application-link/applicatio
 import { WerkvoorraadItem } from '@behandeling/domain/werkvoorraad-item';
 import { werkvoorraadRow } from '@behandeling/domain/werkvoorraad-item-view';

-/** Organism: the behandelaar's queue as CIBG "aanvragen" rows (WP-64) — composition
+/** Organism: the behandelaar's queue as CIBG "aanvragen" rows — composition
    of the two existing shared/ui molecules, no new atom. Each row links to the
-    beoordeling detail page (WP-65). */
+    beoordeling detail page. */
@Component({
  selector: 'app-werkvoorraad-list',
  imports: [ApplicationListComponent, ApplicationLinkComponent],
@@ -10,10 +10,10 @@ import { WerkvoorraadStore } from '@behandeling/application/werkvoorraad.store';
 import { WerkvoorraadListComponent } from '@behandeling/ui/werkvoorraad-list/werkvoorraad-list.component';

 /**
- * Page: the behandelaar's werkvoorraad (WP-64) — the behandelportal's landing page.
+ * Page: the behandelaar's werkvoorraad — the behandelportal's landing page.
 * Deny-by-default capability gate (`aanvraag:beoordelen`), same idiom as ssp's
 * AdminCasesPage: a denial alert for a non-behandelaar, the queue for one. Opening
- * a case's detail is out of scope here (WP-65).
+ * a case's detail is out of scope here.
 */
@Component({
  selector: 'app-werkvoorraad-page',
@@ -69,7 +69,7 @@ export class WerkvoorraadPage {
  private loadRequested = false;
  constructor() {
    // Load once the capability resolves to allowed (a 403 GET would be wasted otherwise) —
-    // same guard-against-the-loop idiom as AdminCasesPage (WP-26 lesson).
+    // same guard-against-the-loop idiom as AdminCasesPage.
    effect(() => {
      if (this.canBeoordelen() && !this.loadRequested) {
        this.loadRequested = true;
@@ -8,7 +8,7 @@ export const NAV_ITEMS: readonly HeaderNavItem[] = [

 /** This app's admin pages — provided to the shared site header via HEADER_ADMIN_LINKS.
    No huisstijl (that's the SSP's brief context) or zaken entry — inherited as-is from
-    WP-61's bootstrap trim, not revisited by this migration. */
+    the bootstrap trim, not revisited by this migration. */
 export const ADMIN_LINKS: readonly AdminLink[] = [
  {
    label: $localize`:@@header.nav.stamdata:Stamdata`,