refactor: strip WP-/RB- ticket refs from apps and libs (RD-18)
204 WP-NN/RB-NN comments named a closed ticket instead of the code they sit next to. git blame already records history and stays correct when code moves; the comment does not. This sweep removes the reference and keeps the sentence, across 95 files in apps/ and libs/ plus the behaviour-spec generator's header text. Eleven references stay: five story files justify an a11y disable per the README's rule, and one line in a11y.mdx documents that convention. Two sentences needed a rewrite, not a deletion, so the reference's meaning survives its removal. behaviour-spec.mdx is regenerated, not hand-edited. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
{/* GENERATED by `npm run gen:behaviour-spec` (scripts/gen-behaviour-spec.mjs) — do not
|
||||
edit. Every bullet below is a real `it()` title or backend test method name, extracted
|
||||
verbatim from the suite. The team rejected Cucumber/Gherkin for BDD scenarios (runtime string
|
||||
matching undoes the compile-time guarantees WP-70 bought, and needs two frameworks for
|
||||
matching undoes the compile-time guarantees the TypeScript compiler bought, and needs two frameworks for
|
||||
.NET+TS) — this page is the replacement: business-readable documentation generated FROM test
|
||||
names, so it can never drift from what the suite actually asserts. A test name changing (or a
|
||||
test being added/removed) is the only way this page changes; hand-editing it is pointless,
|
||||
@@ -108,13 +108,13 @@ classes.
|
||||
|
||||
### beheer
|
||||
|
||||
#### StamdataStore undo/redo (WP-32)
|
||||
#### StamdataStore undo/redo
|
||||
|
||||
- records a cell edit, undoes and redoes it
|
||||
- records addRow and undoes it
|
||||
- clears history when switching table
|
||||
|
||||
#### StamdataStore.download (RB-28)
|
||||
#### StamdataStore.download
|
||||
|
||||
- does not call the presenter while the two-clause guard blocks (nothing dirty yet)
|
||||
- does not call the presenter while previewing a date, even with edits
|
||||
@@ -186,14 +186,14 @@ classes.
|
||||
- flushes a pending debounced edit immediately and clears the pending flag
|
||||
- is a no-op when no edit is pending
|
||||
|
||||
#### BriefStore.load — 404 tolerance (RB-22)
|
||||
#### BriefStore.load — 404 tolerance
|
||||
|
||||
- a 404 drives exactly one reset(), which populates the store
|
||||
- a second 404 does not drive a second reset()
|
||||
|
||||
#### BriefStore.previewLetter
|
||||
|
||||
- opens the composed letter via BLOB_PRESENTER on success (RB-28)
|
||||
- opens the composed letter via BLOB_PRESENTER on success
|
||||
- surfaces the error without opening a tab on failure
|
||||
|
||||
#### BriefStore.revealBigNummer (PRD-0002 §5c)
|
||||
@@ -206,7 +206,7 @@ classes.
|
||||
- sends no X-Role/X-Subject headers outside isDevMode()
|
||||
- sends X-Role (and X-Subject when known) under isDevMode()
|
||||
|
||||
#### OrgTemplateStore.proefbrief (RB-28)
|
||||
#### OrgTemplateStore.proefbrief
|
||||
|
||||
- opens the rendered proefbrief via BLOB_PRESENTER on success
|
||||
- surfaces the error without opening a tab on failure
|
||||
@@ -372,7 +372,7 @@ classes.
|
||||
- low uren requires the scholing question, and punten only once scholing is followed
|
||||
- buitenland gewerkt requires land and hours abroad before advancing
|
||||
- gaNaarStap corrects an earlier answer without losing later ones
|
||||
- raising uren above the threshold after answering scholing drops both fields (WP-69 §6)
|
||||
- raising uren above the threshold after answering scholing drops both fields
|
||||
- SetPolicy (server-owned threshold) can turn an already-answered uren into one that now requires scholing
|
||||
|
||||
#### intake hasProgress
|
||||
@@ -419,8 +419,8 @@ classes.
|
||||
- reaches Submitting ONLY with valid answers
|
||||
- punten is required only when aanvullende scholing was gevolgd
|
||||
- low hours requires the scholing answer before submit
|
||||
- does not require punten for a hidden question (WP-69 §6)
|
||||
- drops punten when raising uren hides the question (WP-69 §6)
|
||||
- does not require punten for a hidden question
|
||||
- drops punten when raising uren hides the question
|
||||
- resolve maps Submitting to Submitted on a successful submit
|
||||
- resolve maps Submitting to Failed on a failed submit
|
||||
|
||||
@@ -501,7 +501,7 @@ classes.
|
||||
|
||||
- resolves ok with the server response on success
|
||||
- folds a rejected submit into a Result error, never throwing
|
||||
- recovers from a create conflict by adopting the existing Concept (WP-35)
|
||||
- recovers from a create conflict by adopting the existing Concept
|
||||
|
||||
#### createSubmitChangeRequest
|
||||
|
||||
@@ -863,8 +863,8 @@ classes.
|
||||
|
||||
- parses a known capability list
|
||||
- parses an empty list (drafter — no capabilities)
|
||||
- recognizes the admin org-template capability (WP-23)
|
||||
- recognizes the behandelportal besluit capability (WP-66)
|
||||
- recognizes the admin org-template capability
|
||||
- recognizes the behandelportal besluit capability
|
||||
- drops unrecognized capability strings instead of rejecting the response
|
||||
- rejects malformed responses instead of trusting them
|
||||
|
||||
@@ -950,7 +950,7 @@ classes.
|
||||
- falls back to default when nothing is set or the value is invalid
|
||||
- setScenario persists the chosen scenario
|
||||
|
||||
#### stripDevParams (WP-37)
|
||||
#### stripDevParams
|
||||
|
||||
- removes ?scenario and ?role so the stored dev value wins on reload
|
||||
- keeps unrelated query params and the path/hash
|
||||
@@ -959,7 +959,7 @@ classes.
|
||||
#### subjectInterceptor
|
||||
|
||||
- stamps X-Subject on an /api/v1/ request once ?subject= has been seen
|
||||
- keeps stamping later requests on the same tab after the query param is gone (WP-33-style stickiness)
|
||||
- keeps stamping later requests on the same tab after the query param is gone (sticky per tab)
|
||||
- leaves a non-API request untouched even when a subject is known
|
||||
- sends no header at all when no subject has ever been seen
|
||||
|
||||
|
||||
Reference in New Issue
Block a user