Files

T

ehoandClaude Opus 5 12f17d9d73 docs: archive the finished backlogs (RD-30)

Two backlog trees are complete: `docs/project/backlog/` (75 files, every
WP done) and `docs/project/refactor-backlog-setup/` (the arc before it).
Move both under `docs/project/archive/` with `git mv`, so history stays
intact through `git log --follow`. `SHOWCASE-ROADMAP.md` moves with them,
because it points at the now-archived backlog README.

Add `docs/project/archive/README.md`. It states that these trees are
historical and names the two directories that are still live.

Repoint every inbound reference named in RD-30's Files table: CLAUDE.md,
the root README, both backend READMEs, `LetterHtml.cs`, `a11y.mdx`, the
`document-feature` and `new-ssp` skills, and the readable-codebase PLAN,
README, and RD-19 ticket. Fix two upward-relative links inside the moved
WP files (WP-68, WP-69) that gained a directory level and would otherwise
break. Repoint `.prettierignore`'s two agent-prompt exclusions to their
new path, so prettier keeps leaving those files' exact wording alone.

Mark RD-30 done and check off its acceptance criteria; flip its README
row to done.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2026-09-08 23:00:38 +02:00

3.8 KiB

Raw Blame History

ADR-C-007 — repoint ADR-0003's WP-67 paths and fix its point 4

Status: implemented · 2026-08-27 · Source finding: 06-adr-conformance.md §ADR-C-007

What was wrong

Two separate defects in one ADR. Every file path in ADR-0003 predated WP-67's monorepo move, and decision point 4 made a claim about app-alert that the code contradicts.

What changed

File	Change
`docs/reference/architecture/0003-...md`	points 1, 2, 4 and both §Consequences bullets rewritten
`CLAUDE.md` §2	the `alert` parenthetical corrected to `skeleton`/`spinner` + a denial for `alert`

No code changed. ADR first, CLAUDE.md to match, one diff.

Paths, each verified

Claimed	Actual
`src/styles.scss`	`libs/shared/styles.scss` — one copy, both apps' `angular.json:41,169`
`src/index.html`	`apps/ssp/src/index.html` and `apps/behandelportal/src/index.html`
`.storybook/`	`.storybook-ssp/` and `.storybook-behandelportal/`
`src/docs/cibg-gaps.mdx`	`libs/shared/docs/cibg-gaps.mdx`

One path in the finding's list needed no change. ADR-C-007 implied point 1's public/cibg-huisstijl/ had moved with the rest. It has not: public/ is still at the repo root, and both apps' angular.json asset entries read "input": "public" (:38, :166). Both Storybook configs serve it as staticDirs: ['../public']. Point 1's vendoring path is left as written; only its index.html clause changed.

Point 4: the finding was right, and understated

ADR-C-007 flagged the .alert half of point 4. Verified: libs/shared/src/ui/alert/alert.component.ts documents itself as a "Thin wrapper over the vendored .feedback feedback-* classes", its template binds .feedback-info/-success/-warning/-error, its only local CSS is a 3-line flex fix, and it carries no CIBG-GAP EXTENSION marker. grep confirms feedback-error is present in public/cibg-huisstijl/css/huisstijl.css — the class is vendored, so alert is not a gap.

The finding missed that the same sentence's second claim is also false. Point 4 said "the header/side-nav use .nav + a local blue bar". They do not:

site-header.component.ts composes the vendored .titlebar and .logo__* classes (grep confirms titlebar in the vendored CSS) and its own comment says the titlebar "keeps its own robijn fill — --ro-layout — untouched".
shell.component.ts emits only .layout, .main, .content, .skip — page scaffolding.
No .nav class appears in either, and neither carries a gap marker.

Both corrections are stated in the amended point 4 rather than silently dropped, so a reader comparing the old text against the code can see which claim was retired and why.

Replacement example chosen

skeleton and spinner, as the finding proposed. Both are in the gap register, both carry markers reading "No loading-skeleton/spinner class in the vendored build", and both are genuinely absent — the cleanest live illustration of the principle point 4 exists to state.

Noted, not fixed: the gap register is still one row short

grep finds 9 CIBG-GAP EXTENSION markers; libs/shared/docs/cibg-gaps.mdx has 8 rows. The missing one is language-switcher. That is ADR-C-008 → RB-32 (batch 6), not this ticket, and it was left alone.

3.8 KiB Raw Blame History