ehoandClaude Opus 4.8
f9b76e7f6a
Lint-enforce two architecture rules that were only documented (ADR-0001), landing the rules with the fixes so the build stays green: - contracts/ imports nothing: dashboard-view.dto.ts is now pure wire shapes (inline string-union enums, no domain imports). The DashboardView FE-view type moves to the adapter, which maps wire → domain (compiler-enforced seam). - ApiClient lives only in infrastructure: change-request-form (UI) no longer injects ApiClient — a new ChangeRequestAdapter owns the client and the submit becomes a createSubmitChangeRequest() command factory (createDraftSync shape). draft-sync's wire-DTO import becomes type-only (allowed via allowTypeImports). - Role type moves to shared/domain/role.ts; the ?role= reader stays in shared/infrastructure/role.ts. - eslint: contracts import-ban + @typescript-eslint/no-restricted-imports on api-client (value-only; type imports permitted; infra + shared/upload exempt). Also fixes a PRE-EXISTING bug found while verifying the flow: change-request-form never imported FormsModule, so (ngSubmit) didn't bind and the submit button did a native form submit (page reload) instead of submitting. Verified end-to-end in the running app: submit → command → adapter → backend → reference, success alert shown. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
19 lines
931 B
TypeScript
19 lines
931 B
TypeScript
import { inject } from '@angular/core';
|
|
import { Result } from '@shared/kernel/fp';
|
|
import { Valid } from '@registratie/domain/change-request.machine';
|
|
import { runSubmit, SUBMIT_FAILED } from '@shared/application/submit';
|
|
import { ChangeRequestAdapter } from '@registratie/infrastructure/change-request.adapter';
|
|
|
|
/**
|
|
* Command factory: binds the change-request adapter (which owns the `ApiClient`)
|
|
* in an injection context and returns the submit function the form calls. Same
|
|
* field-initializer shape as `createStore`/`createDraftSync`, so the UI holds an
|
|
* application command — not the network client. Returns a `Result`, never a thrown
|
|
* error, so the form's reduce can branch on the outcome.
|
|
*/
|
|
export function createSubmitChangeRequest() {
|
|
const adapter = inject(ChangeRequestAdapter);
|
|
return (data: Valid): Promise<Result<string, string>> =>
|
|
runSubmit(() => adapter.changeRequest(data), SUBMIT_FAILED);
|
|
}
|