ehoandClaude Sonnet 5
6bc00a917c
Two work packages in one commit because both edit Program.cs and splitting
them would leave a commit that does not build.
WP-72 — deletes POST /api/v1/intakes and /herregistraties. Both were dead
from the UI (the wizard submits via /applications/{id}/submit) and strictly
less capable: they minted a bare reference and wrote no Aanvraag, made no
ZGW call, and did no document-ownership check. The shared Submit(...) helper
survives — /registrations and /change-requests still use it. WP-69 hardened
/intakes with a 400 last session; removing the surface is the stronger fix,
and WP-69's /applications/{id}/submit enforcement is untouched.
WP-73 — RegistrationStatus becomes an abstract record with three sealed
variants behind a private base ctor, so only Geregistreerd carries a
herregistratie deadline and reden is required on Geschorst/Doorgehaald
(matching the FE union, which was already right). HerregistratieRule
.IsStatusConsistent and its test are deleted: the type now guarantees what
the runtime check was for, and the test could no longer construct the
illegal state it existed to catch.
Aanvraag splits into a Concept | Submitted | Decided union with the EF row
demoted to AanvraagEntity behind a two-way mapper. Submitted carries a
non-null Referentie and SubmittedAt, and Decided.Afgewezen/MeerInfoGevraagd
require a Toelichting — so the five Referentie! null-forgiving derefs in
StatusAt are gone, not merely suppressed. IZaakSource.CreateZaak narrows to
Aanvraag.Submitted, removing the same class of deref in both zaak sources.
Draft is now cleared on submit rather than lingering: ApplicationStore's
doc-comment claimed "Concept only" but Submit never cleared it. Verified
nothing reads a submitted aanvraag's draft (draft-sync's applyResume only
resumes unsubmitted wizards), so the comment is now true instead of
aspirational.
No migration, no schema change, no wire change — RegistrationStatusDto and
the application DTOs are byte-identical, confirmed against a live swagger.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
53 lines
2.4 KiB
C#
53 lines
2.4 KiB
C#
using BigRegister.Api.Data;
|
|
using BigRegister.Domain.Applications;
|
|
using BigRegister.Domain.Beoordeling;
|
|
using BigRegister.Tests.Builders;
|
|
|
|
namespace BigRegister.Tests.Domain;
|
|
|
|
public class BeoordelingRuleTests
|
|
{
|
|
[Theory]
|
|
[InlineData(AanvraagStatusTag.Ingediend, true)]
|
|
[InlineData(AanvraagStatusTag.InBehandeling, true)]
|
|
[InlineData(AanvraagStatusTag.MeerInfoGevraagd, true)]
|
|
[InlineData(AanvraagStatusTag.Goedgekeurd, false)]
|
|
[InlineData(AanvraagStatusTag.Afgewezen, false)]
|
|
public void Only_open_statuses_are_decidable(AanvraagStatusTag tag, bool expected) =>
|
|
Assert.Equal(expected, BeoordelingRules.CanDecide(tag));
|
|
|
|
// WP-68 (F6): the toelichting rule, moved here from an inline endpoint check.
|
|
[Theory]
|
|
[InlineData(Besluit.Goedkeuren, false)]
|
|
[InlineData(Besluit.Afwijzen, true)]
|
|
[InlineData(Besluit.MeerInfoOpvragen, true)]
|
|
public void Only_a_non_approval_requires_a_toelichting(Besluit besluit, bool expected) =>
|
|
Assert.Equal(expected, BeoordelingRules.RequiresToelichting(besluit));
|
|
|
|
// WP-68 (T3): the transition table at the AGGREGATE level, not just against a bare tag —
|
|
// an Aanvraag whose BesluitStatus already records a terminal decision computes a terminal
|
|
// StatusAt, and CanDecide refuses a further besluit regardless of which one. Pins the
|
|
// domain statement "Afgewezen/Goedgekeurd → no further besluit" independent of the
|
|
// endpoint's own (integration-level) Already_decided_case_rejects_a_further_besluit.
|
|
// WP-70: built via Given, not a hand-rolled Aanvraag literal — Decided(Besluit.Afwijzen) with
|
|
// no toelichting simply couldn't compile as a fixture here.
|
|
[Theory]
|
|
[InlineData(Besluit.Goedkeuren)]
|
|
[InlineData(Besluit.Afwijzen)]
|
|
public void A_terminal_decision_refuses_any_further_besluit(Besluit recorded)
|
|
{
|
|
var now = DateTimeOffset.UtcNow;
|
|
var toelichting = recorded == Besluit.Goedkeuren ? null : "toelichting";
|
|
var aanvraag = Given.Concept(owner: "test").Submitted().Decided(recorded, toelichting).Build();
|
|
Assert.False(BeoordelingRules.CanDecide(aanvraag.StatusAt(now).Tag!.Value));
|
|
}
|
|
|
|
[Fact]
|
|
public void MeerInfoOpvragen_is_not_terminal_a_further_besluit_is_still_legal()
|
|
{
|
|
var now = DateTimeOffset.UtcNow;
|
|
var aanvraag = Given.Concept(owner: "test").Submitted().Decided(Besluit.MeerInfoOpvragen, "toelichting").Build();
|
|
Assert.True(BeoordelingRules.CanDecide(aanvraag.StatusAt(now).Tag!.Value));
|
|
}
|
|
}
|