Acts on the showcase review. Four workstreams; all tests green (npm run lint, 70 FE tests, ng build, 33 backend tests). Enforcement + CI: - eslint.config.mjs bans `any` and enforces layer/context boundaries (domain ≠ Angular; herregistratie → registratie → shared, auth → shared); `npm run lint` added; ajv 6 scoped to ESLint via nested override. - .github/workflows/ci.yml: FE lint+check:tokens+test+build, backend dotnet test, and an API-client drift check. One form idiom (the headline finding): - change-request-form converged onto the wizard pattern — change-request.machine.ts (Model/Msg/reduce + value objects) + submit-change-request.ts (Result) + a real POST /api/v1/change-requests (server re-validates). Spec + story added; the detail page no longer holds an ad-hoc success signal. Resilience/observability seam: - api-client.provider.ts: request timeout, X-Correlation-Id, Idempotency-Key for writes; comments naming the retry/auth seams. - Backend logs correlation id + a no-PII submit-audit line; /api/v1 prefix + backward-compat note; client regenerated. Quick wins: - Dev tooling excluded from prod: scenario.interceptor wired only under isDevMode() (?scenario= inert in prod); debug panel @if(isDev) (tree-shaken out). - src/environments + apiBaseUrl into provideApiClient (angular.json fileReplacements). - Backend /health + /health/ready. - Debug view PII-minimised (redactProfile: name/address/DOB redacted, BIG masked). - IntakePolicyAdapter (removes inline resource in the intake wizard). - README de-staled; CLAUDE.md gains EN/NL + forms-one-idiom + lint/CI notes. - Stories: text-input, link, data-row, site-header, site-footer, change-request-form. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
125 lines
4.3 KiB
C#
125 lines
4.3 KiB
C#
using BigRegister.Domain.Diplomas;
|
|
using BigRegister.Domain.Registrations;
|
|
using BigRegister.Domain.Submissions;
|
|
|
|
namespace BigRegister.Tests;
|
|
|
|
public class HerregistratieRuleTests
|
|
{
|
|
private static Registration Active(DateOnly deadline) => new(
|
|
"19012345601", "Test", "Arts",
|
|
new DateOnly(2012, 9, 1), new DateOnly(1985, 3, 14),
|
|
new RegistrationStatus(StatusTag.Geregistreerd, HerregistratieDatum: deadline));
|
|
|
|
[Fact]
|
|
public void Eligible_within_window()
|
|
{
|
|
var (eligible, reason) = HerregistratieRule.Evaluate(
|
|
Active(new DateOnly(2027, 3, 1)), today: new DateOnly(2026, 6, 26));
|
|
Assert.True(eligible);
|
|
Assert.Contains("12 maanden", reason);
|
|
}
|
|
|
|
[Fact]
|
|
public void Not_eligible_before_window()
|
|
{
|
|
var (eligible, _) = HerregistratieRule.Evaluate(
|
|
Active(new DateOnly(2027, 3, 1)), today: new DateOnly(2025, 1, 1));
|
|
Assert.False(eligible);
|
|
}
|
|
|
|
[Fact]
|
|
public void Eligible_on_window_boundary()
|
|
{
|
|
// window opens exactly 12 months before the deadline
|
|
var (eligible, _) = HerregistratieRule.Evaluate(
|
|
Active(new DateOnly(2027, 3, 1)), today: new DateOnly(2026, 3, 1));
|
|
Assert.True(eligible);
|
|
}
|
|
|
|
[Fact]
|
|
public void Suspended_is_not_eligible()
|
|
{
|
|
var reg = Active(new DateOnly(2027, 3, 1)) with
|
|
{
|
|
Status = new RegistrationStatus(StatusTag.Geschorst, GeschorstTot: new DateOnly(2027, 1, 1), Reden: "x"),
|
|
};
|
|
var (eligible, _) = HerregistratieRule.Evaluate(reg, today: new DateOnly(2026, 6, 26));
|
|
Assert.False(eligible);
|
|
}
|
|
|
|
[Fact]
|
|
public void Status_consistency_invariant()
|
|
{
|
|
Assert.True(HerregistratieRule.IsStatusConsistent(
|
|
new RegistrationStatus(StatusTag.Geregistreerd, HerregistratieDatum: new DateOnly(2027, 3, 1))));
|
|
Assert.False(HerregistratieRule.IsStatusConsistent(
|
|
new RegistrationStatus(StatusTag.Geregistreerd)));
|
|
}
|
|
}
|
|
|
|
public class DiplomaRuleTests
|
|
{
|
|
private static Diploma Diploma(string opleiding, bool engelstalig) =>
|
|
new("x", "naam", "instelling", 2011, opleiding, engelstalig);
|
|
|
|
[Theory]
|
|
[InlineData("geneeskunde", "Arts")]
|
|
[InlineData("verpleegkunde", "Verpleegkundige")]
|
|
[InlineData("onbekend-programma", "Onbekend")]
|
|
public void Profession_is_derived_from_program(string opleiding, string expected) =>
|
|
Assert.Equal(expected, DiplomaRules.ProfessionFor(Diploma(opleiding, false)));
|
|
|
|
[Fact]
|
|
public void English_diploma_requires_dutch_proficiency()
|
|
{
|
|
var questions = DiplomaRules.QuestionsFor(Diploma("geneeskunde", engelstalig: true));
|
|
Assert.Single(questions);
|
|
Assert.Equal("nl-taalvaardigheid", questions[0].Id);
|
|
}
|
|
|
|
[Fact]
|
|
public void Dutch_diploma_has_no_policy_questions() =>
|
|
Assert.Empty(DiplomaRules.QuestionsFor(Diploma("geneeskunde", engelstalig: false)));
|
|
|
|
[Fact]
|
|
public void Manual_diploma_gets_maximal_set()
|
|
{
|
|
var questions = DiplomaRules.ManualQuestions();
|
|
Assert.Equal(3, questions.Count);
|
|
Assert.Equal(new[] { "nl-taalvaardigheid", "diploma-erkend", "toelichting" },
|
|
questions.Select(q => q.Id));
|
|
}
|
|
|
|
[Fact]
|
|
public void Manual_professions_match_known_programs() =>
|
|
Assert.Equal(new[] { "Arts", "Verpleegkundige", "Fysiotherapeut", "Apotheker", "Tandarts" },
|
|
DiplomaRules.ManualProfessions());
|
|
}
|
|
|
|
public class SubmissionRuleTests
|
|
{
|
|
[Fact]
|
|
public void Manual_diploma_is_rejected() =>
|
|
Assert.NotNull(SubmissionRules.RejectRegistratie("handmatig"));
|
|
|
|
[Fact]
|
|
public void Duo_diploma_is_accepted() =>
|
|
Assert.Null(SubmissionRules.RejectRegistratie("duo"));
|
|
|
|
[Fact]
|
|
public void Zero_hours_is_rejected() =>
|
|
Assert.NotNull(SubmissionRules.RejectZeroUren(0));
|
|
|
|
[Fact]
|
|
public void Worked_hours_are_accepted() =>
|
|
Assert.Null(SubmissionRules.RejectZeroUren(40));
|
|
|
|
[Theory]
|
|
[InlineData("Lange Voorhout 9", "2514 EA", null)] // valid
|
|
[InlineData("", "2514 EA", "Vul straat en huisnummer in.")]
|
|
[InlineData("Straat 1", "nope", "Voer een geldige postcode in, bijv. 1234 AB.")]
|
|
public void Change_request_is_validated(string straat, string postcode, string? expected) =>
|
|
Assert.Equal(expected, SubmissionRules.RejectChangeRequest(straat, postcode));
|
|
}
|