Edwin van den Houdt
d08f3877f7
Acts on the showcase review. Four workstreams; all tests green (npm run lint, 70 FE tests, ng build, 33 backend tests). Enforcement + CI: - eslint.config.mjs bans `any` and enforces layer/context boundaries (domain ≠ Angular; herregistratie → registratie → shared, auth → shared); `npm run lint` added; ajv 6 scoped to ESLint via nested override. - .github/workflows/ci.yml: FE lint+check:tokens+test+build, backend dotnet test, and an API-client drift check. One form idiom (the headline finding): - change-request-form converged onto the wizard pattern — change-request.machine.ts (Model/Msg/reduce + value objects) + submit-change-request.ts (Result) + a real POST /api/v1/change-requests (server re-validates). Spec + story added; the detail page no longer holds an ad-hoc success signal. Resilience/observability seam: - api-client.provider.ts: request timeout, X-Correlation-Id, Idempotency-Key for writes; comments naming the retry/auth seams. - Backend logs correlation id + a no-PII submit-audit line; /api/v1 prefix + backward-compat note; client regenerated. Quick wins: - Dev tooling excluded from prod: scenario.interceptor wired only under isDevMode() (?scenario= inert in prod); debug panel @if(isDev) (tree-shaken out). - src/environments + apiBaseUrl into provideApiClient (angular.json fileReplacements). - Backend /health + /health/ready. - Debug view PII-minimised (redactProfile: name/address/DOB redacted, BIG masked). - IntakePolicyAdapter (removes inline resource in the intake wizard). - README de-staled; CLAUDE.md gains EN/NL + forms-one-idiom + lint/CI notes. - Stories: text-input, link, data-row, site-header, site-footer, change-request-form. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
19 lines
674 B
TypeScript
19 lines
674 B
TypeScript
import type { Meta, StoryObj } from '@storybook/angular';
|
|
import { DataRowComponent } from './data-row.component';
|
|
|
|
const meta: Meta<DataRowComponent> = {
|
|
title: 'Molecules/Data Row',
|
|
component: DataRowComponent,
|
|
render: (args) => ({
|
|
props: args,
|
|
// Rows live inside an RHC data-summary list (dt/dd); wrap so it renders in context.
|
|
template: `<dl class="rhc-data-summary"><app-data-row [key]="key" [value]="value" /></dl>`,
|
|
}),
|
|
args: { key: 'BIG-nummer', value: '19012345601' },
|
|
};
|
|
export default meta;
|
|
type Story = StoryObj<DataRowComponent>;
|
|
|
|
export const Default: Story = {};
|
|
export const Empty: Story = { args: { key: 'Tweede naam', value: '' } };
|