From 733ba711734780e1edd93678c376e88defb35588 Mon Sep 17 00:00:00 2001 From: Niek Otten Date: Mon, 28 Sep 2026 12:56:10 +0000 Subject: [PATCH] fix(acl): keep the integration tests out of Stryker's solution (closes #174) (#188) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit closes #174 Took fix option 3, cut down: removed `Acl.IntegrationTests` from `services/acl/Acl.slnx`. Only Stryker reads that file. `make build`, `make lint` and `make unit` use the root `register-referentie.slnx`, and `Dockerfile.integration` targets the csproj directly, so nothing else changes. A comment in the slnx and a note in `docs/runbooks/ci.md` explain why the project is left out. **Verified locally** (`cd services/acl && dotnet stryker`): - `Number of tests found: 86` (was 94); the `8 tests are failing` warning is gone. - Final score **90.45 %**, the same as before. Tests that fail their initial run were never used to kill mutants, so the number was not depressed, only unverified. Re-baselined from this clean run: `break: 90` stays (§5, never lower). No test-first commit: this changes build config only. The check is the Stryker initial-run log above. 🤖 Generated with [Claude Code](https://claude.com/claude-code)Reviewed-on: https://git.labs.respellion.tech/eho/register-referentie/pulls/188 --- docs/runbooks/ci.md | 3 +++ services/acl/Acl.slnx | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/runbooks/ci.md b/docs/runbooks/ci.md index 44ba84f..26ded11 100644 --- a/docs/runbooks/ci.md +++ b/docs/runbooks/ci.md @@ -60,6 +60,9 @@ make mutation # dotnet tool restore + dotnet stryker on the ACL Config lives in [`services/acl/stryker-config.json`](../../services/acl/stryker-config.json). It runs in **solution mode** against `Acl.slnx`, mutating the two projects under test (`Acl.Application`, `Acl.Infrastructure`); `Acl.Api` has no tests and is skipped. +`Acl.slnx` leaves out `Acl.IntegrationTests`: it needs a live OpenZaak, and Stryker +runs every test project in the solution, so keeping it in makes 8 tests fail in the +initial run (#174). **Baseline (the ratchet):** the ACL is the first service with branching logic, so it sets the repo-wide baseline. Observed score **95%**; enforced `break` threshold **90%** diff --git a/services/acl/Acl.slnx b/services/acl/Acl.slnx index aa02b3b..20c3c10 100644 --- a/services/acl/Acl.slnx +++ b/services/acl/Acl.slnx @@ -1,7 +1,9 @@ + -