All checks were successful
## What & why Before this change the self-service confirmation and the openbaar register showed **different** identifiers, so a citizen could not look their registration back up (#78). Now both surface the same **reference**: - **domain → ACL (write):** the domain `registrationId` is set as the zaak's `identificatie` on `POST /zaken`. - **event-subscriber → ACL (read):** the subscriber reads the zaak's `identificatie` back through the ACL (§8.1 — only the ACL talks to ZGW) via a new `POST /zaken/reference`, and stores it on the projection row **and** the `processed_notifications` replay log. - **BFF + openbaar:** the public view exposes `id/status/reference` (never bsn/naam) and searches by id or reference; the register's "Referentie" column shows the reference. Storing the reference in the replay log keeps ADR-0008's **rebuild-is-log-only** invariant intact — `/admin/rebuild` reproduces the reference without re-reading the ACL. Decision recorded in **ADR-0012**. ## Definition of Done - [x] Linked issue: #78 - [x] Tests written first; red → green per layer - [x] Unit + acceptance green (`make unit`): domain 49, acl 27, bff 20, event-subscriber 19, acceptance 7 - [x] Frontend lint + test green (`nx run-many -t lint test`) - [x] Mutation ≥ break(90): acl 100%, event-subscriber 100%, bff 100%, domain 98.41% (pre-existing FlowableWorkflowClient baseline, untouched) - [x] e2e extended: confirmation reference == register reference - [x] openapi.json + api-client regenerated (drift guard green) - [x] ADR-0012 added; demo-script note appended - [x] `Acl__BaseUrl` wired for the subscriber in compose closes #78 Reviewed-on: #79
42 lines
1.5 KiB
C#
42 lines
1.5 KiB
C#
using EventSubscriber.Application;
|
|
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace Projection.ReadModel;
|
|
|
|
/// <summary>EF Core implementation of the notification log. Idempotency is enforced atomically
|
|
/// by the primary key on <c>key</c>: a duplicate insert raises a unique violation, which is
|
|
/// caught and reported as "already recorded" rather than failing the request.</summary>
|
|
public sealed class EfNotificationLog(ProjectionDbContext db) : INotificationLog
|
|
{
|
|
public async Task<bool> TryRecordAsync(RecordedNotification notification, CancellationToken ct = default)
|
|
{
|
|
db.ProcessedNotifications.Add(new ProcessedNotificationRow
|
|
{
|
|
Key = notification.Key,
|
|
Actie = notification.Actie,
|
|
ZaakId = notification.ZaakId,
|
|
Resource = notification.Resource,
|
|
Reference = notification.Reference,
|
|
ReceivedAt = DateTimeOffset.UtcNow,
|
|
});
|
|
|
|
try
|
|
{
|
|
await db.SaveChangesAsync(ct);
|
|
return true;
|
|
}
|
|
catch (DbUpdateException)
|
|
{
|
|
// Already recorded by an earlier (or concurrent) delivery — drop this duplicate.
|
|
db.ChangeTracker.Clear();
|
|
return false;
|
|
}
|
|
}
|
|
|
|
public async Task<IReadOnlyList<RecordedNotification>> AllAsync(CancellationToken ct = default)
|
|
=> await db.ProcessedNotifications
|
|
.OrderBy(r => r.ReceivedAt)
|
|
.Select(r => new RecordedNotification(r.Key, r.Actie, r.ZaakId, r.Resource, r.Reference))
|
|
.ToListAsync(ct);
|
|
}
|