not
0904df8db0
## What & why S-10b: the self-service **diploma upload** is now real. After submitting, the citizen picks a PDF and uploads it; the portal base64-encodes it client-side → BFF → domain → **ACL**, which stores it in the ZGW **Documenten (DRC) API** as an `enkelvoudiginformatieobject` and relates it to the zaak, then the `WachtOpDocumenten` wait completes and the case advances to beoordeling. Per §8.1 only the ACL talks to ZGW. Closes #103 Mechanism in **ADR-0018** (proposal #107). Builds on S-10a (#102). The zaak-close-on-expiry item is carved to **#106 (S-10c)**. ## Definition of Done - [x] Linked Gitea issue (above). - [x] Failing test committed before the implementation (red→green per layer). - [x] Conventional Commits referencing the issue (`refs #103`). - [ ] CI green — all Gitea Actions jobs (pending on this PR). - [x] `docker compose up` health unaffected (ACL boots on a placeholder informatieobjecttype URL; the real one is injected by verify-domain). - [x] Docs updated (ADR-0018, demo-script, BACKLOG + S-10c). - [x] ADR added (`docs/architecture/adr-0018-diploma-upload-via-acl-documenten.md`). - [x] Demo note in `docs/demo-script.md`. ## Notes for reviewers - **ACL** (`OpenZaakGateway.StoreDocumentAsync` + `AclService.StoreDiplomaAsync` + `POST /documenten`) reuses the existing gateway patterns (ZGW Bearer, buffered non-chunked body, **no CRS** — Documenten isn't geo). Unit-tested via the stub handler; an **integration test** stores a real document against live OpenZaak (verify-acl). - **Transport:** base64 JSON on every hop (portal encodes client-side) — I deviated from proposal #107's multipart to keep one contract shape and avoid `IFormFile`/antiforgery/multipart-client plumbing; fine at diploma size (ADR-0018 §Alternatives). - **Infra:** `seed_catalogus.py` seeds + publishes a "Diploma" `informatieobjecttype` and relates it to the zaaktype (while both concept); `verify-domain` injects its URL into the ACL. No new ZGW scopes (seed applicatie has `heeft_alle_autorisaties`). - **e2e:** uploads a real PDF (`setInputFiles`) after the openbaar INGEDIEND row confirms the zaak is open (so storage doesn't race the OpenZaak worker). - **Scope boundary:** the ZGW zaak is not set to a cancellation status on 30-day expiry — that's #106 (S-10c). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed-on: #108
67 lines
2.7 KiB
C#
67 lines
2.7 KiB
C#
using Acceptance.Support;
|
|
using Acl.Application;
|
|
using Reqnroll;
|
|
using Xunit;
|
|
|
|
namespace Acceptance.Steps;
|
|
|
|
/// <summary>Bindings for <c>EenZaakOpenen.feature</c>. Reqnroll creates one
|
|
/// instance per scenario, so instance fields hold scenario-scoped state.</summary>
|
|
[Binding]
|
|
public sealed class EenZaakOpenenSteps
|
|
{
|
|
private readonly InMemoryZaakGateway _gateway = new();
|
|
private DomainRegistration? _registration;
|
|
private AclDefaults? _defaults;
|
|
private DateOnly _today;
|
|
private Uri? _returnedUrl;
|
|
|
|
[Given("a domain registration for BSN \"(.*)\"")]
|
|
public void GivenADomainRegistrationForBsn(string bsn)
|
|
=> _registration = new DomainRegistration(bsn, "ACC-REF-1");
|
|
|
|
[Given("the ACL is configured with these defaults:")]
|
|
public void GivenTheAclIsConfiguredWithTheseDefaults(DataTable defaults)
|
|
{
|
|
var values = ToFieldMap(defaults);
|
|
_defaults = new AclDefaults
|
|
{
|
|
Bronorganisatie = values["bronorganisatie"],
|
|
VerantwoordelijkeOrganisatie = values["verantwoordelijkeOrganisatie"],
|
|
Vertrouwelijkheidaanduiding = values["vertrouwelijkheidaanduiding"],
|
|
ZaaktypeUrl = new Uri(values["zaaktype"]),
|
|
InformatieobjecttypeUrl = new Uri("http://openzaak/catalogi/api/v1/informatieobjecttypen/dip"),
|
|
};
|
|
}
|
|
|
|
[Given("today is \"(.*)\"")]
|
|
public void GivenTodayIs(string date)
|
|
=> _today = DateOnly.Parse(date);
|
|
|
|
[When("the domain asks the ACL to open a zaak")]
|
|
public async Task WhenTheDomainAsksTheAclToOpenAZaak()
|
|
{
|
|
var service = new AclService(_gateway, _defaults!, new FixedClock(_today));
|
|
_returnedUrl = await service.OpenZaakAsync(_registration!);
|
|
}
|
|
|
|
[Then("a zaak is created with these default-filled fields")]
|
|
public void ThenAZaakIsCreatedWithTheseDefaultFilledFields(DataTable expected)
|
|
{
|
|
var request = Assert.IsType<ZaakRequest>(_gateway.Captured);
|
|
var fields = ToFieldMap(expected);
|
|
Assert.Equal(fields["bronorganisatie"], request.Bronorganisatie);
|
|
Assert.Equal(fields["verantwoordelijkeOrganisatie"], request.VerantwoordelijkeOrganisatie);
|
|
Assert.Equal(fields["vertrouwelijkheidaanduiding"], request.Vertrouwelijkheidaanduiding);
|
|
Assert.Equal(fields["zaaktype"], request.Zaaktype.ToString());
|
|
Assert.Equal(fields["startdatum"], request.Startdatum.ToString("yyyy-MM-dd"));
|
|
}
|
|
|
|
[Then("the ACL returns the URL of the created zaak")]
|
|
public void ThenTheAclReturnsTheUrlOfTheCreatedZaak()
|
|
=> Assert.Equal(InMemoryZaakGateway.CreatedZaakUrl, _returnedUrl);
|
|
|
|
private static Dictionary<string, string> ToFieldMap(DataTable table)
|
|
=> table.Rows.ToDictionary(r => r["field"], r => r["value"]);
|
|
}
|