Niek Otten
1c185e6686
All checks were successful
## What & why S-09b (#75, split from #10) — the **approval flow** that completes the walking skeleton. A behandelaar can now approve a submitted registration; the entry flips from `INGEDIEND` to `INGESCHREVEN` in the public register. Flow: `POST /registrations/{id}/approve` (domain) → ACL sets the zaak eindstatus (ZGW `/statussen`) → OpenZaak → NRC → event-subscriber → projection → openbaar. ## Changes (bottom-up, each red→green TDD) - **Domain** — `RegistrationStatus.Ingeschreven` + `Registration.Approve()` (guards: opened zaak, only from INGEDIEND); `ApproveRegistration` use case (idempotent) + temp `POST /registrations/{id}/approve` endpoint; `IAclClient.ApproveZaakAsync`. - **ACL** — resolves the zaaktype's **eindstatus** from the catalogus (`isEindstatus` / highest volgnummer) and POSTs a ZGW status; exposed as `POST /statussen`. Unit + real-OpenZaak integration test. - **Event-subscriber** — binds NRC `hoofdObject`, projects a `status`/`create` as `INGESCHREVEN` keyed on the zaak (updates the existing row), **without reading OpenZaak** (§8.1). Retains the ZGW `resource` in the log (new column + EF migration) so a rebuild reproduces the status. - **e2e** — extended: submit → public INGEDIEND → approve → public INGESCHREVEN. - **Docs** — ADR-0011 (the two non-obvious decisions + the walking-skeleton assumption) + demo note. ## Key decisions (see ADR-0011) - **ACL discovers the eindstatus** (chosen over injecting a statustype URL): no new config/seed plumbing, domain stays ZGW-ignorant. - **Any post-creation status-set ⇒ INGESCHREVEN**: in the walking skeleton the only status ever set after creation is the approval, and the subscriber may not read ZGW — documented to tighten when more transitions arrive (S-12+). ## Verification - All .NET unit suites green locally (domain 47, acl 11, event-subscriber 14, bff 16, acceptance 7); Release build + `dotnet format` clean. - No new compose config (the eindstatus-discovery approach avoided it). - The real-OpenZaak integration test (ACL status-set) and the full submit→approve→visible e2e run in CI `verify-stack` (live NRC→projection + selectielijst egress, not reproducible locally). closes #75 Reviewed-on: #77
40 lines
2.1 KiB
C#
40 lines
2.1 KiB
C#
namespace EventSubscriber.Application;
|
|
|
|
/// <summary>
|
|
/// The durable log of notifications the subscriber has accepted. It is both the idempotency
|
|
/// guard (a replayed notification is recognised and dropped) and the rebuild source: the
|
|
/// projection is a derived artefact (PRD §8.4) regenerated by replaying this log, so a rebuild
|
|
/// needs no access to OpenZaak (CLAUDE.md §8.1). Implemented in Infrastructure over Postgres.
|
|
/// </summary>
|
|
public interface INotificationLog
|
|
{
|
|
/// <summary>
|
|
/// Record a notification. Returns <c>true</c> if it was newly recorded, <c>false</c> if an
|
|
/// entry with the same key already existed (a duplicate delivery). Must be atomic so that
|
|
/// concurrent duplicate deliveries cannot both observe <c>true</c>.
|
|
/// </summary>
|
|
Task<bool> TryRecordAsync(RecordedNotification notification, CancellationToken ct = default);
|
|
|
|
/// <summary>Every accepted notification, for rebuilding the projection.</summary>
|
|
Task<IReadOnlyList<RecordedNotification>> AllAsync(CancellationToken ct = default);
|
|
}
|
|
|
|
/// <summary>A notification that has been accepted, retaining what a rebuild needs to recompute its
|
|
/// projection row — including the ZGW <c>resource</c>, which distinguishes a zaak-create (INGEDIEND)
|
|
/// from a status-set (INGESCHREVEN) so a rebuild reproduces the right status.</summary>
|
|
public sealed record RecordedNotification(string Key, string Actie, string ZaakId, string Resource);
|
|
|
|
/// <summary>The read projection store. Owned by the projection bounded context (ADR-0008); the
|
|
/// subscriber writes to it and the projection-api reads it.</summary>
|
|
public interface IProjectionStore
|
|
{
|
|
/// <summary>Insert or update the row for <see cref="RegisterEntry.Id"/>. Idempotent on the id.</summary>
|
|
Task UpsertAsync(RegisterEntry entry, CancellationToken ct = default);
|
|
|
|
/// <summary>Remove every row — the first step of a rebuild.</summary>
|
|
Task ClearAsync(CancellationToken ct = default);
|
|
|
|
/// <summary>Every projection row (used by tests and the rebuild verification).</summary>
|
|
Task<IReadOnlyList<RegisterEntry>> AllAsync(CancellationToken ct = default);
|
|
}
|