not
4777ff2b1d
## What & why S-10a, the **workflow/timeout spine** of the (split) document-upload slice: the registratie process now parks at a **`WachtOpDocumenten`** user task with an **interrupting `P30D` boundary timer**. When the documents arrive the task completes and the process continues into the diploma routing (S-13) → Beoordelen; if the 30 days lapse, the timer cancels the wait, runs a `RegistratieVerlopen` external-worker task, and the domain expires the aggregate to a new terminal status **`Verlopen`**. Backend only — the real upload trigger (portal → BFF → ACL → Documenten API) is S-10b (#103). Closes #102 Mechanism recorded in **ADR-0017**; opened as proposal #104. Mirrors the S-14 escalation (boundary-timer + external-worker) and S-11 withdrawal (interrupting cancel) patterns. ## Definition of Done - [x] Linked Gitea issue (above). - [x] Failing test committed before the implementation (red→green pairs per layer). - [x] Implementation makes the test pass. - [x] Conventional Commits referencing the issue (`refs #102`). - [ ] CI green — all Gitea Actions jobs (pending on this PR). - [x] `docker compose up` health unaffected (no new services; deploy path unchanged). - [x] Docs updated (ADR-0017, demo-script, BACKLOG split). - [x] ADR added (`docs/architecture/adr-0017-document-wait-timeout-cancellation.md`). - [x] Demo note in `docs/demo-script.md`. ## Notes for reviewers - **Domain** (`Registration.Expire()` + `Verlopen`), **application** (`ExpireRegistrationWorker`), **infra** (`RegistratieVerlopenProcessor`/`Pump`, `IRegistratieVerlopenClient`, Flowable acquire/complete + `CompleteDocumentWaitAsync`) — the timeout counterpart to the OpenZaak/escalation worker trios; idempotent per §8.6. - **BPMN** verified live against a `flowable-rest` probe: complete `WachtOpDocumenten` → routes to Beoordelen; fire the P30D timer → `RegistratieVerlopen` job (carrying `registrationId`) + the wait task cancelled. `verify-domain` exercises both branches in-stack (completes the wait in every existing block; fires the timer and asserts `Verlopen` in a new block). - **Scope boundary:** on expiry the aggregate goes `Verlopen` and the process ends, but the ZGW *zaak* is not yet set to a cancellation status — that needs a new ACL method + statustype seeding and is folded into S-10b (noted in ADR-0017). - `CompleteDocumentWaitAsync` is built and HTTP-tested here but not yet called from a domain endpoint; S-10b wires the upload trigger to it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed-on: #105
24 lines
1.3 KiB
Gherkin
24 lines
1.3 KiB
Gherkin
# language: en
|
|
# Drives S-10a (#102). After the zaak is opened the process parks at WachtOpDocumenten with an
|
|
# INTERRUPTING 30-day boundary timer. If the documents do not arrive in time the timer cancels the
|
|
# task and parks a RegistratieVerlopen job (ADR-0017) which the timeout worker drains, expiring the
|
|
# registration to VERLOPEN. Documents received before the timer fires close the wait, so no expiry
|
|
# happens. This scenario exercises the timeout worker against an in-memory Flowable stand-in; the timer
|
|
# firing live is verify-domain.
|
|
Feature: Een documenttermijn laten verlopen
|
|
Als registerbeheerder wil ik dat een aanvraag waarvoor de documenten niet binnen 30 dagen binnen zijn
|
|
automatisch vervalt zodat onvolledige aanvragen niet blijven liggen.
|
|
|
|
Scenario: Zonder documenten binnen 30 dagen vervalt de registratie
|
|
Given a registration parked at the WachtOpDocumenten task
|
|
When the 30-day document timer fires
|
|
And the document-timeout worker runs
|
|
Then the registration is verlopen
|
|
|
|
Scenario: Tijdig aangeleverde documenten laten de registratie niet vervallen
|
|
Given a registration parked at the WachtOpDocumenten task
|
|
When the documents arrive before the timer fires
|
|
And the 30-day document timer fires
|
|
And the document-timeout worker runs
|
|
Then the registration is not verlopen
|