not
4fe9915816
## What & why
S-17: a BIG inscription is valid for a fixed term; before it lapses the zorgprofessional must herregistreren. This adds a **daily herregistratie reminder sweep**.
- **Domain:** `Approve(ingeschrevenOp)` now stamps the inscription moment; `HerregistratieVoor` derives the deadline (inscription + 5-year validity); `HerregistratieReminderDue(asOf)` is the single rule (inside the 90-day window, inscribed, not yet reminded); `MarkHerregistratieReminderVerstuurd()` is idempotent.
- **Store:** `FindDueForHerregistratieReminderAsync(asOf)` — the sweep's candidate set, filtered on the aggregate's own rule (no duplicated policy).
- **Application:** `HerregistratieReminderSweep` — pure over the store + an injected `TimeProvider`; flags + persists each due inscription, returns the reminded ids.
- **Infra/API:** `HerregistratieReminderJob` (Quartz `IJob`) fires the sweep on a daily cron (03:00, overridable via `Quartz__Cron`) and logs the count. `GET /registrations/{id}` surfaces `herregistratieVoor` + `herregistratieReminderVerstuurd`.
**Decisions (both raised with you before coding):** use Quartz.NET as the PRD names it — a genuine cron concern, distinct from the queue-draining pumps, which stay as-is (**ADR-0022**, proposal #120); and the reminder's observable effect is a flag on the aggregate + a log line (no outbound notification infra in v1). No coupling rule (§8) is touched — Quartz is internal to the Domain Service.
Closes #18
Closes #120
## Definition of Done
- [x] Linked Gitea issue (above).
- [x] Failing test committed before the implementation (red→green per layer: domain rule, store query, sweep).
- [x] Implementation makes the test pass; refactor commit for the 90-day knob.
- [x] Conventional Commits referencing the issue (`refs #18`).
- [ ] CI green — awaiting Gitea Actions.
- [ ] `docker compose up` reaches green health checks within 3 minutes — API boots locally with Quartz initialised; verified in CI compose smoke.
- [x] Docs updated — ADR-0022, demo-script, BACKLOG.
- [x] ADR added — `docs/architecture/adr-0022-quartz-scheduler.md`.
- [x] Demo note in `docs/demo-script.md`.
## Notes for reviewers
- **Ripple:** `Approve()` gained the inscription moment, so the two approving handlers (`ApproveRegistration`, `BeoordeelRegistratie`) now take an injected `TimeProvider`; existing tests pass a fixed clock. All three `IRegistrationStore` implementers (prod, unit fake, acceptance) got the new query.
- **Calibration knobs:** validity (5y) and reminder lead time (90d) are domain constants marked with `ponytail:` comments; promotion path to beheer config (S-15) noted in the ADR.
- **Mutation:** the Quartz job shell is excluded from Stryker, mirroring the pumps; all rule/sweep/query logic is covered.
- Local: 152 domain unit tests green; API boots with the Quartz scheduler and `/health` green.
Reviewed-on: #121
68 lines
2.6 KiB
C#
68 lines
2.6 KiB
C#
using Big.Application;
|
|
using Big.Domain;
|
|
|
|
namespace Big.Tests;
|
|
|
|
// S-17 (#18): the sweep behind the Quartz job. It reminds every inscription whose herregistratie
|
|
// reminder is due, marks each so a re-fire is a no-op (§8.6), and returns the reminded ids. Pure over
|
|
// the store + an injected clock — no Quartz here.
|
|
public class HerregistratieReminderSweepTests
|
|
{
|
|
private static readonly DateTimeOffset Now = new(2026, 7, 23, 0, 0, 0, TimeSpan.Zero);
|
|
|
|
private static Registration Inscribed(string bsn, DateTimeOffset ingeschrevenOp)
|
|
{
|
|
var registration = Registration.Submit(bsn);
|
|
registration.AttachZaak(FakeAclClient.DefaultZaakUrl);
|
|
registration.Approve(ingeschrevenOp);
|
|
return registration;
|
|
}
|
|
|
|
// Inscribed exactly (geldigheid - herinneringstermijn) before Now: the reminder window is open.
|
|
private static Registration Due(string bsn)
|
|
=> Inscribed(bsn, Now - Registration.HerregistratieGeldigheid + Registration.Herinneringstermijn);
|
|
|
|
[Fact]
|
|
public async Task Reminds_and_persists_every_due_inscription_and_returns_their_ids()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
var a = Due("123456782");
|
|
var b = Due("111111110");
|
|
var freshlyInscribed = Inscribed("222222222", Now); // not yet in the window
|
|
store.Seed(a);
|
|
store.Seed(b);
|
|
store.Seed(freshlyInscribed);
|
|
|
|
var reminded = await new HerregistratieReminderSweep(store, new FixedClock(Now)).SweepAsync();
|
|
|
|
Assert.Equal(new HashSet<RegistrationId> { a.Id, b.Id }, reminded.ToHashSet());
|
|
Assert.True((await store.GetAsync(a.Id))!.HerregistratieReminderVerstuurd);
|
|
Assert.True((await store.GetAsync(b.Id))!.HerregistratieReminderVerstuurd);
|
|
Assert.False((await store.GetAsync(freshlyInscribed.Id))!.HerregistratieReminderVerstuurd);
|
|
Assert.Equal(2, store.SaveCount);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task A_second_sweep_reminds_no_one_again()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
store.Seed(Due("123456782"));
|
|
var sweep = new HerregistratieReminderSweep(store, new FixedClock(Now));
|
|
|
|
await sweep.SweepAsync();
|
|
var second = await sweep.SweepAsync();
|
|
|
|
Assert.Empty(second);
|
|
Assert.Equal(1, store.SaveCount); // only the first sweep persisted anything
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Reminds_no_one_when_nothing_is_due()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
store.Seed(Inscribed("123456782", Now)); // freshly inscribed — deadline is 5 years off
|
|
|
|
Assert.Empty(await new HerregistratieReminderSweep(store, new FixedClock(Now)).SweepAsync());
|
|
}
|
|
}
|