Niek Otten
9997da8beb
All checks were successful
## What & why Before this change the self-service confirmation and the openbaar register showed **different** identifiers, so a citizen could not look their registration back up (#78). Now both surface the same **reference**: - **domain → ACL (write):** the domain `registrationId` is set as the zaak's `identificatie` on `POST /zaken`. - **event-subscriber → ACL (read):** the subscriber reads the zaak's `identificatie` back through the ACL (§8.1 — only the ACL talks to ZGW) via a new `POST /zaken/reference`, and stores it on the projection row **and** the `processed_notifications` replay log. - **BFF + openbaar:** the public view exposes `id/status/reference` (never bsn/naam) and searches by id or reference; the register's "Referentie" column shows the reference. Storing the reference in the replay log keeps ADR-0008's **rebuild-is-log-only** invariant intact — `/admin/rebuild` reproduces the reference without re-reading the ACL. Decision recorded in **ADR-0012**. ## Definition of Done - [x] Linked issue: #78 - [x] Tests written first; red → green per layer - [x] Unit + acceptance green (`make unit`): domain 49, acl 27, bff 20, event-subscriber 19, acceptance 7 - [x] Frontend lint + test green (`nx run-many -t lint test`) - [x] Mutation ≥ break(90): acl 100%, event-subscriber 100%, bff 100%, domain 98.41% (pre-existing FlowableWorkflowClient baseline, untouched) - [x] e2e extended: confirmation reference == register reference - [x] openapi.json + api-client regenerated (drift guard green) - [x] ADR-0012 added; demo-script note appended - [x] `Acl__BaseUrl` wired for the subscriber in compose closes #78 Reviewed-on: #79
50 lines
1.9 KiB
C#
50 lines
1.9 KiB
C#
using Acceptance.Support;
|
|
using EventSubscriber.Application;
|
|
using Reqnroll;
|
|
using Xunit;
|
|
|
|
namespace Acceptance.Steps;
|
|
|
|
/// <summary>Bindings for <c>RegisterProjectieBijwerken.feature</c> (S-06). Reqnroll creates
|
|
/// one instance per scenario, so instance fields hold scenario-scoped state.</summary>
|
|
[Binding]
|
|
public sealed class RegisterProjectieBijwerkenSteps
|
|
{
|
|
private const string ZaakBase = "http://openzaak:8000/zaken/api/v1/zaken/";
|
|
|
|
private readonly InMemoryNotificationLog _log = new();
|
|
private readonly InMemoryProjectionStore _store = new();
|
|
private readonly NotificationProjector _projector;
|
|
private Notification? _notification;
|
|
|
|
public RegisterProjectieBijwerkenSteps()
|
|
=> _projector = new NotificationProjector(_log, _store, new InMemoryAclReferenceClient());
|
|
|
|
[Given("a zaak is created in OpenZaak with id \"(.*)\"")]
|
|
public void GivenAZaakIsCreatedInOpenZaakWithId(string id)
|
|
=> _notification = new Notification("zaken", "zaak", "create", new Uri(ZaakBase + id));
|
|
|
|
[When("the NRC notification for that zaak is delivered to the event subscriber")]
|
|
public Task WhenTheNotificationIsDelivered()
|
|
=> _projector.HandleAsync(_notification!);
|
|
|
|
[When("the same NRC notification is delivered again")]
|
|
public Task WhenTheSameNotificationIsDeliveredAgain()
|
|
=> _projector.HandleAsync(_notification!);
|
|
|
|
[Then("the register projection contains a row for \"(.*)\" with status \"(.*)\"")]
|
|
public async Task ThenTheProjectionContainsARowWithStatus(string id, string status)
|
|
{
|
|
var entry = Assert.Single(await _store.AllAsync());
|
|
Assert.Equal(id, entry.Id);
|
|
Assert.Equal(status, entry.Status);
|
|
}
|
|
|
|
[Then("the register projection contains exactly one row for \"(.*)\"")]
|
|
public async Task ThenTheProjectionContainsExactlyOneRowFor(string id)
|
|
{
|
|
await _store.AllAsync();
|
|
Assert.Single(_store.RowsFor(id));
|
|
}
|
|
}
|