Some checks failed
CI / lint (pull_request) Successful in 1m11s
CI / build (pull_request) Successful in 1m6s
CI / unit (pull_request) Successful in 1m23s
CI / frontend (pull_request) Successful in 2m45s
CI / mutation (pull_request) Successful in 6m3s
CI / verify-stack (pull_request) Failing after 13m34s
The new gateway/use-case code left surviving mutants (empty NoCoverage on the ACL gateway status-set, plus unasserted error messages, null-guards, and the persist call). Add stub-handler tests for SetZaakToEindstatusAsync (eindstatus resolution, POST framing, failure paths) and assert the approve use case's messages, null handling and SaveAsync. Local Stryker: acl 100%, domain 98.4%, event-subscriber 100%. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
90 lines
3.3 KiB
C#
90 lines
3.3 KiB
C#
using Big.Application;
|
|
using Big.Domain;
|
|
|
|
namespace Big.Tests;
|
|
|
|
public class ApproveRegistrationTests
|
|
{
|
|
private static Registration WithZaak(string bsn = "123456782")
|
|
{
|
|
var registration = Registration.Submit(bsn);
|
|
registration.AttachZaak(FakeAclClient.DefaultZaakUrl);
|
|
return registration;
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Approving_sets_the_zaak_status_via_the_acl_and_marks_the_registration_ingeschreven()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
var acl = new FakeAclClient();
|
|
var registration = WithZaak();
|
|
store.Seed(registration);
|
|
var handler = new ApproveRegistration(store, acl);
|
|
|
|
await handler.HandleAsync(new ApproveRegistrationCommand(registration.Id));
|
|
|
|
var saved = await store.GetAsync(registration.Id);
|
|
Assert.Equal(RegistrationStatus.Ingeschreven, saved!.Status);
|
|
Assert.Equal(FakeAclClient.DefaultZaakUrl, acl.ApprovedZaakUrl);
|
|
Assert.Equal(1, acl.ApproveCallCount);
|
|
// The approved aggregate is persisted (not just mutated in memory).
|
|
Assert.Equal(1, store.SaveCount);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Rejects_a_null_command_without_touching_the_store_or_acl()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
var acl = new FakeAclClient();
|
|
var handler = new ApproveRegistration(store, acl);
|
|
|
|
await Assert.ThrowsAsync<ArgumentNullException>(() => handler.HandleAsync(null!));
|
|
Assert.Equal(0, acl.ApproveCallCount);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Approving_an_unknown_registration_throws_and_does_not_call_the_acl()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
var acl = new FakeAclClient();
|
|
var handler = new ApproveRegistration(store, acl);
|
|
|
|
var ex = await Assert.ThrowsAsync<InvalidOperationException>(
|
|
() => handler.HandleAsync(new ApproveRegistrationCommand(RegistrationId.New())));
|
|
Assert.Contains("No registration", ex.Message);
|
|
Assert.Equal(0, acl.ApproveCallCount);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Approving_before_the_zaak_is_opened_throws_without_calling_the_acl()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
var acl = new FakeAclClient();
|
|
var registration = Registration.Submit("123456782"); // no zaak yet
|
|
store.Seed(registration);
|
|
var handler = new ApproveRegistration(store, acl);
|
|
|
|
var ex = await Assert.ThrowsAsync<InvalidOperationException>(
|
|
() => handler.HandleAsync(new ApproveRegistrationCommand(registration.Id)));
|
|
Assert.Contains("no zaak", ex.Message);
|
|
Assert.Equal(0, acl.ApproveCallCount);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Re_approving_an_already_ingeschreven_registration_is_idempotent()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
var acl = new FakeAclClient();
|
|
var registration = WithZaak();
|
|
store.Seed(registration);
|
|
var handler = new ApproveRegistration(store, acl);
|
|
|
|
await handler.HandleAsync(new ApproveRegistrationCommand(registration.Id));
|
|
await handler.HandleAsync(new ApproveRegistrationCommand(registration.Id));
|
|
|
|
// The second approval is a no-op: the ACL is not asked to set the status again.
|
|
Assert.Equal(1, acl.ApproveCallCount);
|
|
Assert.Equal(RegistrationStatus.Ingeschreven, (await store.GetAsync(registration.Id))!.Status);
|
|
}
|
|
}
|