not
ccae27b3da
## What & why S-13: a diploma's origin decides its route. A **DMN** (`diploma-eligibility`) is evaluated inline by the registratie process as a **`businessRuleTask`**; an exclusive gateway routes a **foreign** (Buitenlands) diploma through a new **CBGVAdvies** user task before `Beoordelen`, a **domestic** one straight there (PRD flow 4). The domain's only new job is carrying the diploma origin and passing it as a process start variable. Chose **Option B (DMN in the BPMN)** over the issue's literal "evaluated by the Domain Service via Workflow Client" wording — keeps the decision a first-class workflow artefact and §8.2 clean. Rationale in **ADR-0016** (proposal #100); noted on this issue. Closes #14 ## Definition of Done - [x] Linked Gitea issue (above). - [x] Failing test committed before the implementation. - [x] Implementation makes the test pass. - [x] Conventional Commits referencing the issue (`refs #14`). - [ ] CI green — all Gitea Actions jobs. - [x] `docker compose up` from a fresh clone reaches green health checks within 3 minutes (additive; DMN deployed by flowable-init). - [x] Docs updated (ADR-0016, demo note). - [x] ADR added (`docs/architecture/adr-0016-diploma-eligibility-dmn.md`). - [x] Demo note in `docs/demo-script.md`. ## How it was built (TDD) - **Domain**: `DiplomaOrigin` on the aggregate + submit command; threaded through the process-start port so the Workflow Client emits a `diplomaOrigin` start variable. Red → green. - **DMN + BPMN**: `workflows/diploma-eligibility.dmn` (origin → route); `businessRuleTask` + exclusive gateway + `CBGVAdvies` user task in `registratie.bpmn`; DMN deployed to Flowable's DMN engine by `flowable-init`. - **Both paths**: `Een diploma op herkomst routeren` acceptance scenarios (origin carried into the process) + unit tests; verify-domain drives a foreign registration through CBGVAdvies→Beoordelen and the domestic one straight to Beoordelen — exercising both DMN branches live. ## Notes for reviewers - Deviation from the issue's Option-A wording is deliberate and recorded (ADR-0016); the outcome is unchanged. - The self-service eIDAS→foreign wiring is out of scope here (this slice is area:domain + area:workflow); the domain submit accepts an optional `diplomaOrigin` so the foreign path is drivable. - Local green: domain unit 109, acceptance 15, `dotnet format`, Release build (0 errors), **domain mutation 95.39%** (break 90). The DMN/`businessRuleTask` REST wiring is CI-verified on verify-stack (no local full-stack run here). Reviewed-on: #101
37 lines
1.8 KiB
C#
37 lines
1.8 KiB
C#
using Big.Domain;
|
|
|
|
namespace Big.Application;
|
|
|
|
/// <summary>A zorgprofessional's request to register, in domain language. No ZGW concepts. The
|
|
/// diploma origin defaults to domestic (the DigiD path); a foreign (eIDAS) submission sets it to
|
|
/// <see cref="DiplomaOrigin.Buitenlands"/> so the workflow's DMN routes it through CBGV-advies (S-13).</summary>
|
|
public sealed record SubmitRegistrationCommand(string Bsn, DiplomaOrigin DiplomaOrigin = DiplomaOrigin.Binnenlands);
|
|
|
|
/// <summary>
|
|
/// The submit use case: create the <see cref="Registration"/> aggregate (INGEDIEND), persist it,
|
|
/// then start the registratie workflow process and record its instance id. It returns as soon as
|
|
/// the process is started — opening the zaak happens later, off the request path, in the external-task
|
|
/// worker (ADR-0009). Persisting <em>before</em> starting the process closes the race where the worker
|
|
/// acquires the OpenZaakAanmaken job before the aggregate it correlates to exists.
|
|
/// </summary>
|
|
public sealed class SubmitRegistration(IRegistrationStore store, IWorkflowClient workflow)
|
|
{
|
|
public async Task<RegistrationId> HandleAsync(SubmitRegistrationCommand command, CancellationToken ct = default)
|
|
{
|
|
ArgumentNullException.ThrowIfNull(command);
|
|
|
|
var registration = Registration.Submit(command.Bsn, command.DiplomaOrigin);
|
|
|
|
// Persist before starting the process so the worker can correlate the OpenZaakAanmaken
|
|
// job back to an aggregate that already exists (ADR-0009).
|
|
await store.SaveAsync(registration, ct);
|
|
|
|
var processInstanceId = await workflow.StartRegistrationProcessAsync(
|
|
registration.Id, registration.DiplomaOrigin, ct);
|
|
registration.RecordProcessStarted(processInstanceId);
|
|
await store.SaveAsync(registration, ct);
|
|
|
|
return registration.Id;
|
|
}
|
|
}
|