All checks were successful
## What & why Second sub-slice of **S-12 (#13)** — the **Workflow Client gains behandelaar user-task operations**, and the process model gains the beoordeling step. - **BPMN:** `registratie.bpmn` now parks at a `Beoordelen` **userTask** (candidate group `behandelaar`) after `OpenZaakAanmaken`; `registrationId` rides along as a process variable so the werkbak can correlate each task to its aggregate. - **Workflow Client** (`IUserTaskClient`, the only code that talks to Flowable §8.2): - `GetOpenBeoordelingenAsync()` — the werkbak (open `Beoordelen` tasks + their `registrationId`) - `ClaimAsync(taskId, behandelaar)` - `CompleteBeoordelingAsync(taskId, besluit)` — carries the decision into the process as the `besluit` variable - **Live integration:** `verify-domain` now drives the full user-task lifecycle against a real Flowable — after the worker opens the zaak, it polls for the task, claims it as `merel-behandelaar`, completes it (`goedkeuren`), and asserts the process finishes. This proves the exact REST contract (`service/runtime/tasks/query` + `…/{id}` claim/complete) the client depends on. The walking skeleton is unaffected: the temporary `/approve` path still sets the zaak status directly; wiring the domain decision to *complete this task* (and driving the werkbak from the BFF) lands in **S-12c**. ## Definition of Done - [x] Linked issue: #13 (umbrella; `refs`, does not close) - [x] Tests first; red → green - [x] Unit + acceptance green (`make unit`): domain 76, acceptance 9 (acl/event-subscriber/bff unaffected) - [x] Mutation ≥ break(90): **domain 100%** (killed the new survivors *and* the pre-existing `FlowableWorkflowClient` baseline) - [x] Live Flowable user-task lifecycle asserted in `verify-domain` - [ ] CI green (pending) Part of #13. Reviewed-on: #83
81 lines
4.0 KiB
C#
81 lines
4.0 KiB
C#
using Big.Domain;
|
|
|
|
namespace Big.Application;
|
|
|
|
/// <summary>
|
|
/// The port to the workflow engine. Implemented by the Workflow Client in Infrastructure — the
|
|
/// <em>only</em> code that talks to Flowable (CLAUDE.md §8.2). The application asks it to start the
|
|
/// registratie process; it never knows Flowable exists.
|
|
/// </summary>
|
|
public interface IWorkflowClient
|
|
{
|
|
/// <summary>
|
|
/// Start one <c>registratie</c> process instance for the given registration, carrying the
|
|
/// registration id so the <c>OpenZaakAanmaken</c> external task can be correlated back to its
|
|
/// aggregate. Returns the process instance id.
|
|
/// </summary>
|
|
Task<string> StartRegistrationProcessAsync(RegistrationId registrationId, CancellationToken ct = default);
|
|
}
|
|
|
|
/// <summary>
|
|
/// The port to the Anti-Corruption Layer. Implemented in Infrastructure by an HTTP client to the
|
|
/// ACL service — the <em>only</em> code that talks to ZGW (CLAUDE.md §8.1). The domain hands over a
|
|
/// bsn; the ACL default-fills the ZGW-mandatory fields (ADR-0003) and returns the created zaak URL.
|
|
/// </summary>
|
|
public interface IAclClient
|
|
{
|
|
/// <summary>Open a zaak for the registration. <paramref name="reference"/> is the registration's
|
|
/// own reference (its id); the ACL records it as the zaak's identificatie so the openbaar register
|
|
/// can show the same reference the zorgprofessional was given (S-09b follow-up, adr-proposal #78).</summary>
|
|
Task<Uri> OpenZaakAsync(string bsn, string reference, CancellationToken ct = default);
|
|
|
|
/// <summary>
|
|
/// Record the approval on the given zaak. The ACL translates this to the ZGW concept — setting
|
|
/// the zaak's final status — which OpenZaak notifies over NRC; the domain never names statustypen.
|
|
/// </summary>
|
|
Task ApproveZaakAsync(Uri zaakUrl, CancellationToken ct = default);
|
|
}
|
|
|
|
/// <summary>
|
|
/// The port to the behandelaar's user tasks in the workflow engine (S-12). Implemented by the
|
|
/// Workflow Client — the only code that talks to Flowable (§8.2). The application lists the open
|
|
/// <c>Beoordelen</c> tasks (the werkbak), claims one for a behandelaar, and completes it with the
|
|
/// decision; it never names Flowable's REST shapes.
|
|
/// </summary>
|
|
public interface IUserTaskClient
|
|
{
|
|
/// <summary>The werkbak: the <c>Beoordelen</c> tasks awaiting a behandelaar, each with the
|
|
/// registration it belongs to.</summary>
|
|
Task<IReadOnlyList<BeoordelingTask>> GetOpenBeoordelingenAsync(CancellationToken ct = default);
|
|
|
|
/// <summary>Claim a beoordeling task for a behandelaar (assigns it to them).</summary>
|
|
Task ClaimAsync(string taskId, string behandelaar, CancellationToken ct = default);
|
|
|
|
/// <summary>Complete a beoordeling task, carrying the decision into the process as the
|
|
/// <c>besluit</c> variable so the workflow can continue on the chosen branch.</summary>
|
|
Task CompleteBeoordelingAsync(string taskId, BeoordelingsBesluit besluit, CancellationToken ct = default);
|
|
}
|
|
|
|
/// <summary>A <c>Beoordelen</c> user task in the werkbak: the Flowable task id (needed to claim and
|
|
/// complete it) and the registration it carries as a process variable.</summary>
|
|
public sealed record BeoordelingTask(string TaskId, RegistrationId RegistrationId);
|
|
|
|
/// <summary>
|
|
/// Persistence port for the <see cref="Registration"/> aggregate. In-memory for the minimal slice
|
|
/// (ADR-0009); an EF-backed store is a documented follow-up, and this port keeps that change additive.
|
|
/// </summary>
|
|
public interface IRegistrationStore
|
|
{
|
|
/// <summary>Insert or update the registration, keyed on its id.</summary>
|
|
Task SaveAsync(Registration registration, CancellationToken ct = default);
|
|
|
|
/// <summary>Load a registration by id, or <c>null</c> if none exists.</summary>
|
|
Task<Registration?> GetAsync(RegistrationId id, CancellationToken ct = default);
|
|
}
|
|
|
|
/// <summary>
|
|
/// An acquired <c>OpenZaakAanmaken</c> external-worker job: the Flowable job id (needed to complete
|
|
/// it) and the registration id it carries as a process variable.
|
|
/// </summary>
|
|
public sealed record OpenZaakJob(string JobId, RegistrationId RegistrationId);
|