rve/learning-platform
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: stop warning about merged themes in curriculum schedule #13

Merged
rve merged 1 commits from fix/issue-12-curriculum-merge-warning into main 2026-06-03 20:08:59 +00:00
Conversation 0 Commits 1 Files Changed 2 +133 -13
rve commented 2026-06-03 20:07:15 +00:00
Owner
Copy Link

Summary

Fixes #12 — the noisy [Curriculum] Schedule generated with warnings: ... log that read like an error in the learning station.

  • With more than 26 themes in the KB the AI is required to merge themes — labels not appearing as week names are expected, not warnings.
  • validateSchedule now only flags missing theme labels when themes_kb <= 26.
  • Adds a real coverage check: warns when learning topics are absent from every week of the schedule (the actual signal worth surfacing).
  • 5 new vitest cases covering merge-vs-no-merge, topic coverage, fact/exclude exemption, and existing hard errors.

Test plan

  • npm test — 90/90 green (5 new tests added)
  • Manual: open Learning Station with the current 47-theme curriculum and confirm the console no longer shows the misleading warning
  • Manual (admin): generate a draft and verify coverage tiles still render

Closes #12

🤖 Generated with Claude Code

## Summary Fixes [#12](https://git.labs.respellion.tech/rve/learning-platform/issues/12) — the noisy `[Curriculum] Schedule generated with warnings: ...` log that read like an error in the learning station. - With more than 26 themes in the KB the AI is *required* to merge themes — labels not appearing as week names are expected, not warnings. - `validateSchedule` now only flags missing theme labels when `themes_kb <= 26`. - Adds a real coverage check: warns when learning topics are absent from every week of the schedule (the actual signal worth surfacing). - 5 new vitest cases covering merge-vs-no-merge, topic coverage, fact/exclude exemption, and existing hard errors. ## Test plan - [x] `npm test` — 90/90 green (5 new tests added) - [ ] Manual: open Learning Station with the current 47-theme curriculum and confirm the console no longer shows the misleading warning - [ ] Manual (admin): generate a draft and verify coverage tiles still render Closes #12 🤖 Generated with [Claude Code](https://claude.com/claude-code)
rve added 1 commit 2026-06-03 20:07:15 +00:00
fix: stop warning about merged themes in curriculum schedule
All checks were successful
On Pull Request to Main / test (pull_request) Successful in 44s
Details
On Pull Request to Main / publish (pull_request) Successful in 1m22s
Details
On Pull Request to Main / deploy-dev (pull_request) Successful in 1m40s
Details
2274de4de7 
When the KB has more than 26 themes the curriculum AI is required to
merge — so theme labels not appearing as week names are expected, not
warnings. The previous validation surfaced this as a console.warn that
read like an error in the learning station console.

- validateSchedule now only flags missing theme labels when themes_kb <= 26
- adds a real coverage check: warns when learning topics are absent from
  every week (the actual signal we care about)
- adds vitest coverage for both behaviours

Closes #12

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rve merged commit 2b2921f6ed into main 2026-06-03 20:08:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
eho lmi lpr not rdi rve
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rve/learning-platform#13
Delete Branch "fix/issue-12-curriculum-merge-warning"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?