ci: fix test-storybook config-dir + add missing behandelportal a11y coverage
CI / changes (pull_request) Successful in 17s
CI / lint (pull_request) Successful in 56s
CI / frontend (pull_request) Successful in 2m31s
CI / backend (pull_request) Successful in 1m57s
CI / e2e (pull_request) Successful in 3m32s
CI / semgrep (pull_request) Successful in 1m13s
CI / api-client-drift (pull_request) Successful in 2m2s
CI / storybook-a11y (pull_request) Successful in 11m42s
CI / changes (pull_request) Successful in 17s
CI / lint (pull_request) Successful in 56s
CI / frontend (pull_request) Successful in 2m31s
CI / backend (pull_request) Successful in 1m57s
CI / e2e (pull_request) Successful in 3m32s
CI / semgrep (pull_request) Successful in 1m13s
CI / api-client-drift (pull_request) Successful in 2m2s
CI / storybook-a11y (pull_request) Successful in 11m42s
WP-67's monorepo split renamed .storybook to .storybook-ssp/ .storybook-behandelportal, but test-storybook still defaulted to the (now nonexistent) plain .storybook dir -- it loads <config-dir>/main.js for test-runner hooks even in --url mode, so every invocation failed with "Could not load main.js in .storybook". Also: test-storybook:ci only ever built+served+tested the ssp instance. Since the split, behandelportal's stories (werkvoorraad, beoordeling, besluit-form, ...) were never axe-tested in CI at all. Added the :behandelportal siblings (mirroring the existing storybook/ build-storybook naming) and wired them into ci-local.sh's --full step and the storybook-a11y GitHub Actions job. Verified directly: ssp 62/180 stories green, behandelportal 45/112 green (including the new besluit-form story), full `ci-local.sh --full` green end-to-end. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -168,6 +168,10 @@ jobs:
|
||||
if: needs.changes.outputs.frontend == 'true'
|
||||
- run: npm run test-storybook:ci
|
||||
if: needs.changes.outputs.frontend == 'true'
|
||||
- run: npm run build-storybook:behandelportal
|
||||
if: needs.changes.outputs.frontend == 'true'
|
||||
- run: npm run test-storybook:ci:behandelportal
|
||||
if: needs.changes.outputs.frontend == 'true'
|
||||
|
||||
backend:
|
||||
needs: changes
|
||||
|
||||
+4
-2
@@ -17,8 +17,10 @@
|
||||
"storybook:behandelportal": "ng run behandelportal:storybook",
|
||||
"build-storybook": "ng run ssp:build-storybook",
|
||||
"build-storybook:behandelportal": "ng run behandelportal:build-storybook",
|
||||
"test-storybook": "test-storybook",
|
||||
"test-storybook:ci": "concurrently -k -s first -n sb,axe \"http-server storybook-static -p 6006 --silent\" \"wait-on tcp:127.0.0.1:6006 && test-storybook --url http://127.0.0.1:6006 --maxWorkers=2\"",
|
||||
"test-storybook": "test-storybook --config-dir .storybook-ssp",
|
||||
"test-storybook:behandelportal": "test-storybook --config-dir .storybook-behandelportal",
|
||||
"test-storybook:ci": "concurrently -k -s first -n sb,axe \"http-server storybook-static -p 6006 --silent\" \"wait-on tcp:127.0.0.1:6006 && test-storybook --config-dir .storybook-ssp --url http://127.0.0.1:6006 --maxWorkers=2\"",
|
||||
"test-storybook:ci:behandelportal": "concurrently -k -s first -n sb,axe \"http-server storybook-static-behandelportal -p 6007 --silent\" \"wait-on tcp:127.0.0.1:6007 && test-storybook --config-dir .storybook-behandelportal --url http://127.0.0.1:6007 --maxWorkers=2\"",
|
||||
"check:tokens": "bash scripts/check-tokens.sh",
|
||||
"dep:check": "depcruise apps/ssp/src libs --config .dependency-cruiser.ssp.js && depcruise apps/behandelportal/src libs --config .dependency-cruiser.behandelportal.js",
|
||||
"dep:graph": "bash scripts/dep-graph.sh",
|
||||
|
||||
+2
-1
@@ -23,7 +23,8 @@ step "showcase snippets drift"; npm run gen:snippets && git diff --exit-code a
|
||||
step "api-client drift"; npm run gen:api && git diff --exit-code libs/shared/src/infrastructure/api-client.ts backend/swagger.json
|
||||
|
||||
if [[ "${1:-}" == "--full" ]]; then
|
||||
step "storybook build + axe"; npm run build-storybook && npm run test-storybook:ci
|
||||
step "storybook build + axe (ssp)"; npm run build-storybook && npm run test-storybook:ci
|
||||
step "storybook build + axe (behandelportal)"; npm run build-storybook:behandelportal && npm run test-storybook:ci:behandelportal
|
||||
fi
|
||||
|
||||
printf '\n\033[1;32m✔ local CI passed\033[0m\n'
|
||||
|
||||
Reference in New Issue
Block a user