Refactor/readable dashboard #2

Merged

eho merged 5 commits from refactor/readable-dashboard into main 2026-09-04 13:19:28 +00:00

Conversation 0 Commits 5 Files Changed 60

+1311 -893

5 Commits

Author	SHA1	Message	Date
ehoandClaude Sonnet 5	c8029d23e2	docs: regenerate behaviour-spec.mdx ... Catches drift accumulated since the Application → Aanvraag rename (Step 1/8, Step 2/8) plus the new tests from this branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-04 15:17:10 +02:00
ehoandClaude Sonnet 5	c7aed8d308	fix: narrow parseBrpAddress's return type instead of leaking the DTO ... BrpAddressDto's fields are generated as optional, so returning it directly from parseBrpAddress lost the narrowing the runtime check already did. This broke the build once registratie-lookup.store.ts assigned the parsed address into a stricter local type. Map to a proper BrpAddress domain shape at the trust boundary instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-04 15:17:06 +02:00
ehoandClaude Sonnet 5	5977efe044	refactor: split dashboard.page.ts into per-concern sections ... Each dashboard section (Mijn aanvragen, Wat moet ik regelen, Mijn registratie, Specialismen, Wat wilt u doen, Beheer) now owns its own store access, async state, and template. DashboardPage becomes pure composition. Extract the repeated RemoteData Success-narrowing pattern into successOf() and the dashboard sort/split logic into sortForDashboard/concepten/ingediend, both with tests. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-04 15:17:02 +02:00
ehoandClaude Opus 5	42e7a1e927	refactor: delete shadow contracts DTOs, parse the generated shape for real (Step 2/8) ... dashboard-view.dto.ts and brp-address.dto.ts each shadowed a generated type: DashboardViewDto was declared twice (hand-written with required fields, generated with everything optional), reconciled only by structural typing. Both are gone. dashboard-view.adapter.ts now imports the generated DashboardViewDto/ RegistrationDto/PersonDto/RegistrationStatusDto directly. Its parse does real work now instead of an identity copy: parseRegistrationStatus validates each status variant's required fields per-tag (the generated type flattens the union, so a Geregistreerd row missing herregistratieDatum previously passed the boundary unnoticed — it no longer does). HerregistratieDecisions moves from contracts/ to domain/registration.ts, so no contracts-typed value reaches a page. brp.adapter.ts drops its own BrpAddressDto shadow the same way. Hand-written contracts/*.dto.ts count: 4 -> 2 (duo-diplomas.dto.ts and stamdata.dto.ts remain — both parse fields codegen can't type at all). Part of the dashboard-readability refactor (see the approved plan). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-09-04 14:36:30 +02:00
ehoandClaude Opus 5	194cccfd02	refactor: rename Application → Aanvraag across the wire (Step 1/8) ... The wire said Application, the domain said Aanvraag — one aggregate with two names at every hop. Rename the backend DTOs and the /applications route to /aanvragen, regenerate the typed client, and rename the frontend adapter/store to match. Renamed: ApplicationSummaryDto/DetailDto, CreateApplicationRequest, SubmitApplicationRequest/Response → Aanvraag* equivalents; ApplicationsAdapter/Store → AanvragenAdapter/Store; applications.adapter.ts/applications.store.ts → aanvragen.*. Left untouched: the admin Case/Zaak vocabulary (/admin/cases, AdminCasesStore) — a separate read model, not part of this rename; the internal BigRegister.Domain.Applications namespace and the Applications EF table (renaming those needs a new EF migration, out of scope here). Part of the dashboard-readability refactor (see the approved plan). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-09-04 14:33:16 +02:00