register-referentie

eho/register-referentie

Fork 0

Author	SHA1	Message	Date
not	d226b6402d	feat(#13 ): S-12c-2 — behandel decide → domain + complete workflow task (#86 ) CI / lint (push) Successful in 1m17s Details CI / build (push) Successful in 1m0s Details CI / unit (push) Successful in 1m8s Details CI / frontend (push) Successful in 2m20s Details CI / mutation (push) Successful in 4m57s Details CI / verify-stack (push) Successful in 7m3s Details ## What & why Second half of S-12c (behandel-portal backend), completing the decision path per ADR-0013: - Domain: `BeoordeelRegistratie` now, after applying the decision (aggregate + ACL for approval), completes the open Flowable `Beoordelen` task for that registration (found by registrationId) with the besluit, so the workflow advances. No open task → the decision still stands (completes nothing); idempotent. - BFF: `POST /behandel/registrations/{id}/decide` behind the medewerker/`behandelaar` policy, forwarding `goedkeuren`/`afwijzen` to the domain. Validates the besluit vocabulary (400 on unknown) without troubling the domain. Behavior: decide is 401 without a token, 403 without the role, 400 for an unknown besluit, 204 (forwarded) for a behandelaar. This completes the behandel backend. S-12d (the Angular behandel-portal + Playwright e2e) closes umbrella #13 and retires the temporary `/approve`. ## Definition of Done - [x] Linked issue: #13 (umbrella, `refs`) - [x] Tests first; red → green per layer - [x] Unit + acceptance green (`make unit`): domain 79, bff 27, acceptance 9 (acl/event-subscriber unaffected) - [x] Beoordeling acceptance scenario asserts task completion (goedkeuren + afwijzen) - [x] openapi.json + api-client regenerated (drift guard passes) - [x] Mutation ≥ break(90): domain 100%, bff 100% - [ ] CI green (pending) Part of #13. Reviewed-on: #86	2026-07-16 06:53:52 +00:00

Author

SHA1

Message

Date

not

d226b6402d

feat(#13 ): S-12c-2 — behandel decide → domain + complete workflow task (#86 )

CI / lint (push) Successful in 1m17s

Details

CI / build (push) Successful in 1m0s

Details

CI / unit (push) Successful in 1m8s

Details

CI / frontend (push) Successful in 2m20s

Details

CI / mutation (push) Successful in 4m57s

Details

CI / verify-stack (push) Successful in 7m3s

Details

## What & why

Second half of **S-12c** (behandel-portal backend), completing the decision path per **ADR-0013**:

- **Domain:** `BeoordeelRegistratie` now, after applying the decision (aggregate + ACL for approval), **completes the open Flowable `Beoordelen` task** for that registration (found by registrationId) with the besluit, so the workflow advances. No open task → the decision still stands (completes nothing); idempotent.
- **BFF:** `POST /behandel/registrations/{id}/decide` behind the medewerker/`behandelaar` policy, forwarding `goedkeuren`/`afwijzen` to the domain. Validates the besluit vocabulary (400 on unknown) without troubling the domain.

Behavior: decide is **401** without a token, **403** without the role, **400** for an unknown besluit, **204** (forwarded) for a behandelaar.

This completes the behandel backend. **S-12d** (the Angular behandel-portal + Playwright e2e) closes umbrella #13 and retires the temporary `/approve`.

## Definition of Done

- [x] Linked issue: #13 (umbrella, `refs`)
- [x] Tests first; red → green per layer
- [x] Unit + acceptance green (`make unit`): domain 79, bff 27, acceptance 9 (acl/event-subscriber unaffected)
- [x] Beoordeling acceptance scenario asserts task completion (goedkeuren + afwijzen)
- [x] openapi.json + api-client regenerated (drift guard passes)
- [x] Mutation ≥ break(90): **domain 100%, bff 100%**
- [ ] CI green (pending)

Part of #13.

Reviewed-on: #86

2026-07-16 06:53:52 +00:00

Compare commits

Diff Content Not Available