register-referentie

eho/register-referentie

Fork 0

Author	SHA1	Message	Date
Niek Otten	1c185e6686	S-09b: Approval flow — temp admin endpoint + status transition to projection (#77 ) All checks were successful CI / lint (push) Successful in 1m25s Details CI / build (push) Successful in 1m13s Details CI / unit (push) Successful in 1m26s Details CI / frontend (push) Successful in 2m35s Details CI / mutation (push) Successful in 6m6s Details CI / verify-stack (push) Successful in 7m34s Details ## What & why S-09b (#75, split from #10) — the approval flow that completes the walking skeleton. A behandelaar can now approve a submitted registration; the entry flips from `INGEDIEND` to `INGESCHREVEN` in the public register. Flow: `POST /registrations/{id}/approve` (domain) → ACL sets the zaak eindstatus (ZGW `/statussen`) → OpenZaak → NRC → event-subscriber → projection → openbaar. ## Changes (bottom-up, each red→green TDD) - Domain — `RegistrationStatus.Ingeschreven` + `Registration.Approve()` (guards: opened zaak, only from INGEDIEND); `ApproveRegistration` use case (idempotent) + temp `POST /registrations/{id}/approve` endpoint; `IAclClient.ApproveZaakAsync`. - ACL — resolves the zaaktype's eindstatus from the catalogus (`isEindstatus` / highest volgnummer) and POSTs a ZGW status; exposed as `POST /statussen`. Unit + real-OpenZaak integration test. - Event-subscriber — binds NRC `hoofdObject`, projects a `status`/`create` as `INGESCHREVEN` keyed on the zaak (updates the existing row), without reading OpenZaak (§8.1). Retains the ZGW `resource` in the log (new column + EF migration) so a rebuild reproduces the status. - e2e — extended: submit → public INGEDIEND → approve → public INGESCHREVEN. - Docs — ADR-0011 (the two non-obvious decisions + the walking-skeleton assumption) + demo note. ## Key decisions (see ADR-0011) - ACL discovers the eindstatus (chosen over injecting a statustype URL): no new config/seed plumbing, domain stays ZGW-ignorant. - Any post-creation status-set ⇒ INGESCHREVEN: in the walking skeleton the only status ever set after creation is the approval, and the subscriber may not read ZGW — documented to tighten when more transitions arrive (S-12+). ## Verification - All .NET unit suites green locally (domain 47, acl 11, event-subscriber 14, bff 16, acceptance 7); Release build + `dotnet format` clean. - No new compose config (the eindstatus-discovery approach avoided it). - The real-OpenZaak integration test (ACL status-set) and the full submit→approve→visible e2e run in CI `verify-stack` (live NRC→projection + selectielijst egress, not reproducible locally). closes #75 Reviewed-on: #77	2026-07-14 09:04:57 +00:00

Author

SHA1

Message

Date

Niek Otten

1c185e6686

S-09b: Approval flow — temp admin endpoint + status transition to projection (#77 )

CI / lint (push) Successful in 1m25s

Details

CI / build (push) Successful in 1m13s

Details

CI / unit (push) Successful in 1m26s

Details

CI / frontend (push) Successful in 2m35s

Details

CI / mutation (push) Successful in 6m6s

Details

CI / verify-stack (push) Successful in 7m34s

Details

## What & why

S-09b (#75, split from #10) — the **approval flow** that completes the walking skeleton. A behandelaar can now approve a submitted registration; the entry flips from `INGEDIEND` to `INGESCHREVEN` in the public register. Flow: `POST /registrations/{id}/approve` (domain) → ACL sets the zaak eindstatus (ZGW `/statussen`) → OpenZaak → NRC → event-subscriber → projection → openbaar.

## Changes (bottom-up, each red→green TDD)

- **Domain** — `RegistrationStatus.Ingeschreven` + `Registration.Approve()` (guards: opened zaak, only from INGEDIEND); `ApproveRegistration` use case (idempotent) + temp `POST /registrations/{id}/approve` endpoint; `IAclClient.ApproveZaakAsync`.
- **ACL** — resolves the zaaktype's **eindstatus** from the catalogus (`isEindstatus` / highest volgnummer) and POSTs a ZGW status; exposed as `POST /statussen`. Unit + real-OpenZaak integration test.
- **Event-subscriber** — binds NRC `hoofdObject`, projects a `status`/`create` as `INGESCHREVEN` keyed on the zaak (updates the existing row), **without reading OpenZaak** (§8.1). Retains the ZGW `resource` in the log (new column + EF migration) so a rebuild reproduces the status.
- **e2e** — extended: submit → public INGEDIEND → approve → public INGESCHREVEN.
- **Docs** — ADR-0011 (the two non-obvious decisions + the walking-skeleton assumption) + demo note.

## Key decisions (see ADR-0011)

- **ACL discovers the eindstatus** (chosen over injecting a statustype URL): no new config/seed plumbing, domain stays ZGW-ignorant.
- **Any post-creation status-set ⇒ INGESCHREVEN**: in the walking skeleton the only status ever set after creation is the approval, and the subscriber may not read ZGW — documented to tighten when more transitions arrive (S-12+).

## Verification

- All .NET unit suites green locally (domain 47, acl 11, event-subscriber 14, bff 16, acceptance 7); Release build + `dotnet format` clean.
- No new compose config (the eindstatus-discovery approach avoided it).
- The real-OpenZaak integration test (ACL status-set) and the full submit→approve→visible e2e run in CI `verify-stack` (live NRC→projection + selectielijst egress, not reproducible locally).

closes #75

Reviewed-on: #77

2026-07-14 09:04:57 +00:00

Compare commits

1 Commits

feat/75-ap ... 1c185e6686

Diff Content Not Available

Compare commits

1 Commits feat/75-ap ... 1c185e6686

Diff Content Not Available

1 Commits

feat/75-ap ... 1c185e6686