feat(portal-beheer): beheer portal + read-only catalogus viewer (closes #130) #133

Merged
not merged 13 commits from feat/130-beheer-catalogi into main 2026-07-24 11:08:18 +00:00
Contributor

What & why

S-15a, the first of the S-15 (#16) split. A new beheer portal (medewerker realm, like behandel) shows the ZTC catalogus — the published zaaktypen — read-only. A beheerder logs in and sees the seeded BIG-REGISTRATIE zaaktype.

Closes #130

The vertical

portal → BFF GET /beheer/catalogi/zaaktypen (medewerker realm + beheerder role) → ACL GET /catalogi/zaaktypen → ZGW Catalogi API.

  • ACL: new read-only GET /catalogi/zaaktypen listing published zaaktypen (reuses the ADR-0021 Catalogi client; public-safe identificatie/omschrijving).
  • BFF: new typed IAclClient + Downstream:Acl:BaseUrl, and GET /beheer/catalogi/zaaktypen behind a new beheerder policy (reuses the medewerker bearer scheme + realm-role lifting). OpenAPI spec + generated Angular client regenerated.
  • Keycloak: beheerder realm role + bram-beheerder test user in the medewerker realm.
  • Frontend: new apps/beheer Angular app (copied from behandel) with a read-only catalogus page; SECURE_API_ROUTES=['/beheer/'].
  • Infra: beheer compose service (port 8143), added to WAIT_SVCS + CI log-dump; a Playwright e2e (beheerder login → catalogus shows BIG-REGISTRATIE).

New boundary → ADR-0025

The BFF now reaches the ACL directly for the catalogus read — a new service-to-service edge (§14). The catalogus is neither a domain nor a projection concern, and §8.1 means only the ACL may read ZGW; routing through the domain would pollute it with a non-domain passthrough. §8.1/§8.3 stay intact. Recorded in ADR-0025.

Definition of Done

  • Failing test committed before each implementation (red→green per layer: ACL, BFF, frontend).
  • Conventional Commits referencing #130.
  • CI green — pending Gitea Actions run.
  • docker compose up brings up beheer (health-gated in WAIT_SVCS).
  • Docs — ADR-0025 + demo-script S-15a note.
  • Demo note in docs/demo-script.md.

Verified locally

lint (dotnet format) ✓ · .NET unit (Acl 57 / Big 152 / EventSubscriber 19 / Bff 40) ✓ · frontend lint+test (8 projects) ✓ · frontend build (4 apps) ✓. Mutation ratchet: added a gateway unit test for the new ListZaaktypenAsync mapping so the ACL score holds. verify-stack (compose smoke + e2e) runs in CI.

Notes for reviewers

  • The BFF drops the ZGW URL from BeheerZaaktype (public-safe: identificatie + omschrijving only).
  • The catalogus e2e asserts on the stable seeded BIG-REGISTRATIE (not a per-test reference), safe on the shared verify stack.
  • Follow-ups: S-15b (#131) default-fill CRUD, S-15c (#132) medewerker-realm MFA.

🤖 Generated with Claude Code

## What & why S-15a, the first of the S-15 (#16) split. A new **beheer** portal (medewerker realm, like behandel) shows the ZTC catalogus — the published zaaktypen — **read-only**. A beheerder logs in and sees the seeded BIG-REGISTRATIE zaaktype. Closes #130 ### The vertical portal → BFF `GET /beheer/catalogi/zaaktypen` (medewerker realm + `beheerder` role) → ACL `GET /catalogi/zaaktypen` → ZGW Catalogi API. - **ACL**: new read-only `GET /catalogi/zaaktypen` listing published zaaktypen (reuses the ADR-0021 Catalogi client; public-safe `identificatie`/`omschrijving`). - **BFF**: new typed `IAclClient` + `Downstream:Acl:BaseUrl`, and `GET /beheer/catalogi/zaaktypen` behind a new `beheerder` policy (reuses the medewerker bearer scheme + realm-role lifting). OpenAPI spec + generated Angular client regenerated. - **Keycloak**: `beheerder` realm role + `bram-beheerder` test user in the medewerker realm. - **Frontend**: new `apps/beheer` Angular app (copied from behandel) with a read-only catalogus page; `SECURE_API_ROUTES=['/beheer/']`. - **Infra**: `beheer` compose service (port 8143), added to `WAIT_SVCS` + CI log-dump; a Playwright e2e (beheerder login → catalogus shows BIG-REGISTRATIE). ### New boundary → ADR-0025 The BFF now reaches the **ACL directly** for the catalogus read — a new service-to-service edge (§14). The catalogus is neither a domain nor a projection concern, and §8.1 means only the ACL may read ZGW; routing through the domain would pollute it with a non-domain passthrough. §8.1/§8.3 stay intact. Recorded in **ADR-0025**. ## Definition of Done - [x] Failing test committed before each implementation (red→green per layer: ACL, BFF, frontend). - [x] Conventional Commits referencing #130. - [x] CI green — pending Gitea Actions run. - [x] `docker compose up` brings up `beheer` (health-gated in `WAIT_SVCS`). - [x] Docs — ADR-0025 + demo-script S-15a note. - [x] Demo note in `docs/demo-script.md`. ## Verified locally lint (`dotnet format`) ✓ · .NET unit (Acl 57 / Big 152 / EventSubscriber 19 / Bff 40) ✓ · frontend lint+test (8 projects) ✓ · frontend build (4 apps) ✓. Mutation ratchet: added a gateway unit test for the new `ListZaaktypenAsync` mapping so the ACL score holds. verify-stack (compose smoke + e2e) runs in CI. ## Notes for reviewers - The BFF drops the ZGW URL from `BeheerZaaktype` (public-safe: identificatie + omschrijving only). - The catalogus e2e asserts on the stable seeded `BIG-REGISTRATIE` (not a per-test reference), safe on the shared verify stack. - Follow-ups: **S-15b** (#131) default-fill CRUD, **S-15c** (#132) medewerker-realm MFA. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
not added this to the Iteration 3 — Beheer & Observability milestone 2026-07-24 09:03:07 +00:00
not added 10 commits 2026-07-24 09:03:07 +00:00
not added the type:slicearea:aclarea:portal-beheerarea:bff labels 2026-07-24 09:03:17 +00:00
not added 1 commit 2026-07-24 09:07:44 +00:00
fix(test): implement ListZaaktypenAsync in the acceptance InMemoryZaakGateway (refs #130)
CI / build (pull_request) Successful in 1m38s
CI / unit (pull_request) Successful in 1m48s
CI / frontend (pull_request) Successful in 4m20s
CI / mutation (pull_request) Failing after 22m12s
CI / verify-stack (pull_request) Failing after 1m28s
CI / lint (pull_request) Successful in 1m48s
b812f42912
not added 1 commit 2026-07-24 09:47:17 +00:00
ci: re-trigger after infra flakes — mutation test-host crash + compose recreate race (refs #130)
CI / build (pull_request) Successful in 1m28s
CI / lint (pull_request) Successful in 1m41s
CI / unit (pull_request) Successful in 1m47s
CI / frontend (pull_request) Successful in 4m0s
CI / mutation (pull_request) Successful in 6m49s
CI / verify-stack (pull_request) Failing after 8m30s
995b55af57
not added 1 commit 2026-07-24 10:09:12 +00:00
fix(test): match the catalogus zaaktype cell exactly, not case-insensitively (refs #130)
CI / build (pull_request) Successful in 1m36s
CI / lint (pull_request) Successful in 1m51s
CI / unit (pull_request) Successful in 1m49s
CI / frontend (pull_request) Successful in 4m24s
CI / mutation (pull_request) Successful in 6m58s
CI / verify-stack (pull_request) Successful in 8m14s
d39b5dff3c
not merged commit 4698c869f3 into main 2026-07-24 11:08:18 +00:00
Sign in to join this conversation.