eho/register-referentie
1
0
Fork 0
Code Issues 16 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

feat(#13): S-12c-2 — behandel decide → domain + complete workflow task #86

Open
not wants to merge 5 commits from feat/13-behandel-decide into main
pull from: feat/13-behandel-decide
merge into: eho:main
Conversation 0 Commits 5 Files Changed 12 +284 -14
not commented 2026-07-15 10:03:26 +00:00
Contributor
Copy Link

What & why

Second half of S-12c (behandel-portal backend), completing the decision path per ADR-0013:

  • Domain: BeoordeelRegistratie now, after applying the decision (aggregate + ACL for approval), completes the open Flowable Beoordelen task for that registration (found by registrationId) with the besluit, so the workflow advances. No open task → the decision still stands (completes nothing); idempotent.
  • BFF: POST /behandel/registrations/{id}/decide behind the medewerker/behandelaar policy, forwarding goedkeuren/afwijzen to the domain. Validates the besluit vocabulary (400 on unknown) without troubling the domain.

Behavior: decide is 401 without a token, 403 without the role, 400 for an unknown besluit, 204 (forwarded) for a behandelaar.

This completes the behandel backend. S-12d (the Angular behandel-portal + Playwright e2e) closes umbrella #13 and retires the temporary /approve.

Definition of Done

  • Linked issue: #13 (umbrella, refs)
  • Tests first; red → green per layer
  • Unit + acceptance green (make unit): domain 79, bff 27, acceptance 9 (acl/event-subscriber unaffected)
  • Beoordeling acceptance scenario asserts task completion (goedkeuren + afwijzen)
  • openapi.json + api-client regenerated (drift guard passes)
  • Mutation ≥ break(90): domain 100%, bff 100%
  • CI green (pending)

Part of #13.

## What & why Second half of **S-12c** (behandel-portal backend), completing the decision path per **ADR-0013**: - **Domain:** `BeoordeelRegistratie` now, after applying the decision (aggregate + ACL for approval), **completes the open Flowable `Beoordelen` task** for that registration (found by registrationId) with the besluit, so the workflow advances. No open task → the decision still stands (completes nothing); idempotent. - **BFF:** `POST /behandel/registrations/{id}/decide` behind the medewerker/`behandelaar` policy, forwarding `goedkeuren`/`afwijzen` to the domain. Validates the besluit vocabulary (400 on unknown) without troubling the domain. Behavior: decide is **401** without a token, **403** without the role, **400** for an unknown besluit, **204** (forwarded) for a behandelaar. This completes the behandel backend. **S-12d** (the Angular behandel-portal + Playwright e2e) closes umbrella #13 and retires the temporary `/approve`. ## Definition of Done - [x] Linked issue: #13 (umbrella, `refs`) - [x] Tests first; red → green per layer - [x] Unit + acceptance green (`make unit`): domain 79, bff 27, acceptance 9 (acl/event-subscriber unaffected) - [x] Beoordeling acceptance scenario asserts task completion (goedkeuren + afwijzen) - [x] openapi.json + api-client regenerated (drift guard passes) - [x] Mutation ≥ break(90): **domain 100%, bff 100%** - [ ] CI green (pending) Part of #13.
not added 5 commits 2026-07-15 10:03:28 +00:00
test(domain): the beoordeling decision completes the Flowable Beoordelen task (refs #13) c005b0d627 
Red — BeoordeelRegistratie has no user-task dependency and doesn't complete the task.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(domain): the beoordeling decision completes the Flowable Beoordelen task (refs #13) 94d5feb6e0 
After applying the decision, BeoordeelRegistratie finds the open Beoordelen task for
the registration and completes it with the besluit so the workflow advances (ADR-0013).
No open task → the decision still stands (completes nothing). DI already provides
IUserTaskClient (S-12b).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
test(bff): /behandel/registrations/{id}/decide auth + forwarding + besluit validation (refs #13) d50a60c98b 
Red — the decide endpoint does not exist yet.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(bff): POST /behandel/registrations/{id}/decide behind the behandelaar policy (refs #13) 4ebc263bdf 
Forwards a behandelaar's goedkeuren/afwijzen to the domain (which applies the decision
and completes the workflow task). Validates the besluit vocabulary (400 on unknown)
without troubling the domain. openapi.json + api-client regenerated.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
test(acceptance): beoordeling scenario asserts the workflow task is completed (refs #13)
All checks were successful
CI / lint (pull_request) Successful in 1m18s
Details
CI / build (pull_request) Successful in 1m12s
Details
CI / unit (pull_request) Successful in 1m4s
Details
CI / frontend (pull_request) Successful in 2m11s
Details
CI / mutation (pull_request) Successful in 5m51s
Details
CI / verify-stack (pull_request) Successful in 8m50s
Details
3cb3ce6956 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
not added the type:slicearea:domainarea:portal-behandelarea:workflowarea:bff labels 2026-07-15 10:03:32 +00:00
All checks were successful
CI / lint (pull_request) Successful in 1m18s
Required
Details
CI / build (pull_request) Successful in 1m12s
Required
Details
CI / unit (pull_request) Successful in 1m4s
Required
Details
CI / frontend (pull_request) Successful in 2m11s
Required
Details
CI / mutation (pull_request) Successful in 5m51s
Required
Details
CI / verify-stack (pull_request) Successful in 8m50s
Required
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/13-behandel-decide:feat/13-behandel-decide
git checkout feat/13-behandel-decide
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area:acl
area:bff
area:docs
area:domain
area:event-subscriber
area:infra
area:portal-behandel
area:portal-beheer
area:portal-openbaar
area:portal-self-service
area:projection
area:workflow
type:adr-proposal
type:bug
type:chore
type:slice
No Label area:bff area:domain area:portal-behandel area:workflow type:slice
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
eho
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eho/register-referentie#86
Delete Branch "feat/13-behandel-decide"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?