not
4698c869f3
## What & why S-15a, the first of the S-15 (#16) split. A new **beheer** portal (medewerker realm, like behandel) shows the ZTC catalogus — the published zaaktypen — **read-only**. A beheerder logs in and sees the seeded BIG-REGISTRATIE zaaktype. Closes #130 ### The vertical portal → BFF `GET /beheer/catalogi/zaaktypen` (medewerker realm + `beheerder` role) → ACL `GET /catalogi/zaaktypen` → ZGW Catalogi API. - **ACL**: new read-only `GET /catalogi/zaaktypen` listing published zaaktypen (reuses the ADR-0021 Catalogi client; public-safe `identificatie`/`omschrijving`). - **BFF**: new typed `IAclClient` + `Downstream:Acl:BaseUrl`, and `GET /beheer/catalogi/zaaktypen` behind a new `beheerder` policy (reuses the medewerker bearer scheme + realm-role lifting). OpenAPI spec + generated Angular client regenerated. - **Keycloak**: `beheerder` realm role + `bram-beheerder` test user in the medewerker realm. - **Frontend**: new `apps/beheer` Angular app (copied from behandel) with a read-only catalogus page; `SECURE_API_ROUTES=['/beheer/']`. - **Infra**: `beheer` compose service (port 8143), added to `WAIT_SVCS` + CI log-dump; a Playwright e2e (beheerder login → catalogus shows BIG-REGISTRATIE). ### New boundary → ADR-0025 The BFF now reaches the **ACL directly** for the catalogus read — a new service-to-service edge (§14). The catalogus is neither a domain nor a projection concern, and §8.1 means only the ACL may read ZGW; routing through the domain would pollute it with a non-domain passthrough. §8.1/§8.3 stay intact. Recorded in **ADR-0025**. ## Definition of Done - [x] Failing test committed before each implementation (red→green per layer: ACL, BFF, frontend). - [x] Conventional Commits referencing #130. - [ ] CI green — pending Gitea Actions run. - [x] `docker compose up` brings up `beheer` (health-gated in `WAIT_SVCS`). - [x] Docs — ADR-0025 + demo-script S-15a note. - [x] Demo note in `docs/demo-script.md`. ## Verified locally lint (`dotnet format`) ✓ · .NET unit (Acl 57 / Big 152 / EventSubscriber 19 / Bff 40) ✓ · frontend lint+test (8 projects) ✓ · frontend build (4 apps) ✓. Mutation ratchet: added a gateway unit test for the new `ListZaaktypenAsync` mapping so the ACL score holds. verify-stack (compose smoke + e2e) runs in CI. ## Notes for reviewers - The BFF drops the ZGW URL from `BeheerZaaktype` (public-safe: identificatie + omschrijving only). - The catalogus e2e asserts on the stable seeded `BIG-REGISTRATIE` (not a per-test reference), safe on the shared verify stack. - Follow-ups: **S-15b** (#131) default-fill CRUD, **S-15c** (#132) medewerker-realm MFA. 🤖 Generated with [Claude Code](https://claude.com/claude-code)Reviewed-on: #133
49 lines
2.8 KiB
TypeScript
49 lines
2.8 KiB
TypeScript
import { defineConfig, devices } from '@playwright/test';
|
||
|
||
// The e2e runs inside the compose network (infra/run-e2e-check.sh); baseURL defaults to the
|
||
// self-service service. Keep timeouts generous — the first navigation triggers the DigiD flow.
|
||
const baseURL = process.env.SELF_SERVICE_URL ?? 'http://self-service';
|
||
// The behandel portal is a second origin the happy path visits (staff approve from the werkbak);
|
||
// it needs the same insecure-origin-as-secure treatment as self-service for the PKCE login (below).
|
||
const behandelURL = process.env.BEHANDEL_URL ?? 'http://behandel';
|
||
// The beheer portal is a third medewerker-realm origin (the read-only catalogus viewer, S-15a); it
|
||
// needs the same insecure-origin-as-secure treatment as the others for the PKCE login (below).
|
||
const beheerURL = process.env.BEHEER_URL ?? 'http://beheer';
|
||
|
||
export default defineConfig({
|
||
testDir: '.',
|
||
timeout: 90_000,
|
||
expect: { timeout: 15_000 },
|
||
retries: 1,
|
||
// Run the specs serially. Each spec drives a full `channel: 'chromium'` browser, and the e2e
|
||
// shares an 8 GB runner with the entire compose stack (OpenZaak, NRC, Keycloak, Flowable, 4×
|
||
// Postgres, every service + 3 portals). Two parallel browsers exhaust memory and the renderer is
|
||
// OOM-killed mid-action ("Page crashed") — fixing the flakiness at its source rather than leaning
|
||
// on `retries` (CLAUDE.md §15). Only two long-running happy-path specs, so serial costs little.
|
||
workers: 1,
|
||
reporter: [['list']],
|
||
use: {
|
||
baseURL,
|
||
trace: 'on-first-retry',
|
||
// The portal is served over plain HTTP on a non-localhost origin (http://self-service) inside the
|
||
// compose network, so it is NOT a secure context — and Web Crypto (`crypto.subtle`) is undefined
|
||
// there. angular-auth-oidc-client needs SubtleCrypto to build the PKCE code challenge, so
|
||
// `authorize()` throws and the login redirect never fires (the login form never appears). In
|
||
// production the portal runs behind HTTPS, where this works. Rather than terminate TLS in the
|
||
// throwaway e2e stack, tell Chromium to treat this origin as secure — which faithfully emulates
|
||
// the production HTTPS context. This flag is only honoured by the full Chromium build (new
|
||
// headless), not Playwright's default headless-shell, so pin `channel: 'chromium'`.
|
||
channel: 'chromium',
|
||
launchOptions: {
|
||
args: [
|
||
`--unsafely-treat-insecure-origin-as-secure=${baseURL},${behandelURL},${beheerURL}`,
|
||
// Write Chromium's shared memory to /tmp instead of the container's small /dev/shm, so a
|
||
// large DOM/heap can't crash the renderer on the memory-constrained runner (belt-and-braces
|
||
// alongside the single worker above).
|
||
'--disable-dev-shm-usage',
|
||
],
|
||
},
|
||
},
|
||
projects: [{ name: 'chromium', use: { ...devices['Desktop Chrome'] } }],
|
||
});
|