Niek Otten
1c185e6686
All checks were successful
## What & why S-09b (#75, split from #10) — the **approval flow** that completes the walking skeleton. A behandelaar can now approve a submitted registration; the entry flips from `INGEDIEND` to `INGESCHREVEN` in the public register. Flow: `POST /registrations/{id}/approve` (domain) → ACL sets the zaak eindstatus (ZGW `/statussen`) → OpenZaak → NRC → event-subscriber → projection → openbaar. ## Changes (bottom-up, each red→green TDD) - **Domain** — `RegistrationStatus.Ingeschreven` + `Registration.Approve()` (guards: opened zaak, only from INGEDIEND); `ApproveRegistration` use case (idempotent) + temp `POST /registrations/{id}/approve` endpoint; `IAclClient.ApproveZaakAsync`. - **ACL** — resolves the zaaktype's **eindstatus** from the catalogus (`isEindstatus` / highest volgnummer) and POSTs a ZGW status; exposed as `POST /statussen`. Unit + real-OpenZaak integration test. - **Event-subscriber** — binds NRC `hoofdObject`, projects a `status`/`create` as `INGESCHREVEN` keyed on the zaak (updates the existing row), **without reading OpenZaak** (§8.1). Retains the ZGW `resource` in the log (new column + EF migration) so a rebuild reproduces the status. - **e2e** — extended: submit → public INGEDIEND → approve → public INGESCHREVEN. - **Docs** — ADR-0011 (the two non-obvious decisions + the walking-skeleton assumption) + demo note. ## Key decisions (see ADR-0011) - **ACL discovers the eindstatus** (chosen over injecting a statustype URL): no new config/seed plumbing, domain stays ZGW-ignorant. - **Any post-creation status-set ⇒ INGESCHREVEN**: in the walking skeleton the only status ever set after creation is the approval, and the subscriber may not read ZGW — documented to tighten when more transitions arrive (S-12+). ## Verification - All .NET unit suites green locally (domain 47, acl 11, event-subscriber 14, bff 16, acceptance 7); Release build + `dotnet format` clean. - No new compose config (the eindstatus-discovery approach avoided it). - The real-OpenZaak integration test (ACL status-set) and the full submit→approve→visible e2e run in CI `verify-stack` (live NRC→projection + selectielijst egress, not reproducible locally). closes #75 Reviewed-on: #77
66 lines
2.9 KiB
C#
66 lines
2.9 KiB
C#
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace Projection.ReadModel;
|
|
|
|
/// <summary>
|
|
/// The read projection's persistence. This single store is the system's rebuildable read model
|
|
/// (PRD §8.4): the Event Subscriber writes to it (projector) and the projection-api reads it
|
|
/// (query). Both processes are the one "Read Projection" bounded context and share this schema —
|
|
/// not a cross-domain DB share (ADR-0008 reconciles this with CLAUDE.md §8.5).
|
|
/// </summary>
|
|
public sealed class ProjectionDbContext(DbContextOptions<ProjectionDbContext> options) : DbContext(options)
|
|
{
|
|
/// <summary>The public-facing register rows (public-safe filtering is tightened in S-09).</summary>
|
|
public DbSet<RegisterEntryRow> RegisterEntries => Set<RegisterEntryRow>();
|
|
|
|
/// <summary>The Event Subscriber's durable log of accepted notifications — idempotency guard and rebuild source.</summary>
|
|
public DbSet<ProcessedNotificationRow> ProcessedNotifications => Set<ProcessedNotificationRow>();
|
|
|
|
protected override void OnModelCreating(ModelBuilder modelBuilder)
|
|
{
|
|
modelBuilder.Entity<RegisterEntryRow>(e =>
|
|
{
|
|
e.ToTable("register_projection");
|
|
e.HasKey(r => r.Id);
|
|
e.Property(r => r.Id).HasColumnName("id");
|
|
e.Property(r => r.Status).HasColumnName("status").IsRequired();
|
|
e.Property(r => r.Bsn).HasColumnName("bsn");
|
|
e.Property(r => r.NaamPlaceholder).HasColumnName("naam_placeholder");
|
|
});
|
|
|
|
modelBuilder.Entity<ProcessedNotificationRow>(e =>
|
|
{
|
|
e.ToTable("processed_notifications");
|
|
e.HasKey(r => r.Key);
|
|
e.Property(r => r.Key).HasColumnName("key");
|
|
e.Property(r => r.Actie).HasColumnName("actie").IsRequired();
|
|
e.Property(r => r.ZaakId).HasColumnName("zaak_id").IsRequired();
|
|
e.Property(r => r.Resource).HasColumnName("resource").IsRequired();
|
|
e.Property(r => r.ReceivedAt).HasColumnName("received_at");
|
|
});
|
|
}
|
|
}
|
|
|
|
/// <summary>A register projection row. <c>Bsn</c>/<c>NaamPlaceholder</c> are deferred (ADR-0008).</summary>
|
|
public sealed class RegisterEntryRow
|
|
{
|
|
public required string Id { get; set; }
|
|
public required string Status { get; set; }
|
|
public string? Bsn { get; set; }
|
|
public string? NaamPlaceholder { get; set; }
|
|
}
|
|
|
|
/// <summary>An accepted notification, retained so the projection can be rebuilt without OpenZaak (§8.1).</summary>
|
|
public sealed class ProcessedNotificationRow
|
|
{
|
|
public required string Key { get; set; }
|
|
public required string Actie { get; set; }
|
|
public required string ZaakId { get; set; }
|
|
|
|
/// <summary>The ZGW resource (e.g. <c>zaak</c> or <c>status</c>) — retained so a rebuild reprojects
|
|
/// the right status without reading OpenZaak (S-09b).</summary>
|
|
public required string Resource { get; set; }
|
|
|
|
public DateTimeOffset ReceivedAt { get; set; }
|
|
}
|