Niek Otten
d226b6402d
All checks were successful
## What & why
Second half of **S-12c** (behandel-portal backend), completing the decision path per **ADR-0013**:
- **Domain:** `BeoordeelRegistratie` now, after applying the decision (aggregate + ACL for approval), **completes the open Flowable `Beoordelen` task** for that registration (found by registrationId) with the besluit, so the workflow advances. No open task → the decision still stands (completes nothing); idempotent.
- **BFF:** `POST /behandel/registrations/{id}/decide` behind the medewerker/`behandelaar` policy, forwarding `goedkeuren`/`afwijzen` to the domain. Validates the besluit vocabulary (400 on unknown) without troubling the domain.
Behavior: decide is **401** without a token, **403** without the role, **400** for an unknown besluit, **204** (forwarded) for a behandelaar.
This completes the behandel backend. **S-12d** (the Angular behandel-portal + Playwright e2e) closes umbrella #13 and retires the temporary `/approve`.
## Definition of Done
- [x] Linked issue: #13 (umbrella, `refs`)
- [x] Tests first; red → green per layer
- [x] Unit + acceptance green (`make unit`): domain 79, bff 27, acceptance 9 (acl/event-subscriber unaffected)
- [x] Beoordeling acceptance scenario asserts task completion (goedkeuren + afwijzen)
- [x] openapi.json + api-client regenerated (drift guard passes)
- [x] Mutation ≥ break(90): **domain 100%, bff 100%**
- [ ] CI green (pending)
Part of #13.
Reviewed-on: #86
66 lines
2.7 KiB
C#
66 lines
2.7 KiB
C#
using Acceptance.Support;
|
|
using Big.Application;
|
|
using Big.Domain;
|
|
using Reqnroll;
|
|
using Xunit;
|
|
|
|
namespace Acceptance.Steps;
|
|
|
|
/// <summary>Bindings for <c>EenRegistratieBeoordelen.feature</c> (S-12). Drives the TakeIntoBehandeling
|
|
/// transition and the BeoordeelRegistratie use case against in-memory ports; one instance per scenario.
|
|
/// Scoped to this feature so its "the registration has status" step does not clash with the identically
|
|
/// phrased (but differently-asserting) step in <see cref="RegistratieIndienenSteps"/>.</summary>
|
|
[Binding]
|
|
[Scope(Feature = "Een registratie beoordelen")]
|
|
public sealed class EenRegistratieBeoordelenSteps
|
|
{
|
|
private readonly InMemoryAclClient _acl = new();
|
|
private readonly InMemoryRegistrationStore _store = new();
|
|
private readonly InMemoryUserTaskClient _tasks = new();
|
|
private RegistrationId _id;
|
|
|
|
[Given("a submitted registration with an opened zaak")]
|
|
public async Task GivenASubmittedRegistrationWithAnOpenedZaak()
|
|
{
|
|
var registration = Registration.Submit("123456782");
|
|
registration.AttachZaak(InMemoryAclClient.OpenedZaakUrl);
|
|
await _store.SaveAsync(registration);
|
|
_id = registration.Id;
|
|
// The process has parked at the Beoordelen user task awaiting the behandelaar.
|
|
_tasks.Open(_id);
|
|
}
|
|
|
|
[When("the behandelaar takes it into behandeling")]
|
|
public async Task WhenTheBehandelaarTakesItIntoBehandeling()
|
|
{
|
|
var registration = await _store.GetAsync(_id);
|
|
registration!.TakeIntoBehandeling();
|
|
await _store.SaveAsync(registration);
|
|
}
|
|
|
|
[When("the behandelaar decides \"(.*)\"")]
|
|
public async Task WhenTheBehandelaarDecides(string besluit)
|
|
=> await new BeoordeelRegistratie(_store, _acl, _tasks).HandleAsync(
|
|
new BeoordeelRegistratieCommand(_id, Enum.Parse<BeoordelingsBesluit>(besluit, ignoreCase: true)));
|
|
|
|
[Then("the registration has status \"(.*)\"")]
|
|
public async Task ThenTheRegistrationHasStatus(string expected)
|
|
{
|
|
var registration = await _store.GetAsync(_id);
|
|
Assert.NotNull(registration);
|
|
Assert.Equal(expected, registration.Status.ToString().ToUpperInvariant());
|
|
}
|
|
|
|
[Then("the zaak's final status is set via the ACL")]
|
|
public void ThenTheZaakFinalStatusIsSetViaTheAcl()
|
|
=> Assert.Equal(InMemoryAclClient.OpenedZaakUrl, _acl.ApprovedZaakUrl);
|
|
|
|
[Then("the ACL is not asked to set the zaak status")]
|
|
public void ThenTheAclIsNotAskedToSetTheZaakStatus()
|
|
=> Assert.Null(_acl.ApprovedZaakUrl);
|
|
|
|
[Then("the beoordeling task is completed with \"(.*)\"")]
|
|
public void ThenTheBeoordelingTaskIsCompletedWith(string besluit)
|
|
=> Assert.Equal(Enum.Parse<BeoordelingsBesluit>(besluit, ignoreCase: true), _tasks.Completed?.Besluit);
|
|
}
|